From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=+WHZEkgbRn1GZtipugYZWIhuk4XxfES0a92pxk+TNa4=; b=DBkvy0NK9CykHdZtUaT89e+b6Y27pzscN8ahqFm4CMwWXSsJByCy67sccdKQlgY8Aq vwsQRJFEnbkMuUHtXP3L/yjY3q4YqZTBY8UJS1AJyH11wU2pwzsI3OXgWrFgIQcSj9WC vXDhlloTMo7pr+v8fqPCeWTNycNcdpV2oXD8Q= Date: Wed, 8 Jul 2020 01:22:27 -0700 From: Kees Cook Message-ID: <202007080108.454C937@keescook> References: <159419296487.2464622.863943877093636532.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <159419296487.2464622.863943877093636532.stgit@dwillia2-desk3.amr.corp.intel.com> Subject: Re: [Tech-board-discuss] [PATCH v2] CodingStyle: Inclusive Terminology List-Id: Public TAB discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dan Williams Cc: ksummit-discuss@lists.linuxfoundation.org, Greg Kroah-Hartman , Randy Dunlap , SeongJae Park , linux-kernel@vger.kernel.org, tech-board-discuss@lists.linuxfoundation.org, Chris Mason , Dave Airlie , torvalds@linux-foundation.org On Wed, Jul 08, 2020 at 12:23:59AM -0700, Dan Williams wrote: > Linux maintains a coding-style and its own idiomatic set of terminology. > Update the style guidelines to recommend replacements for the terms > master/slave and blacklist/whitelist. > > Link: http://lore.kernel.org/r/159389297140.2210796.13590142254668787525.stgit@dwillia2-desk3.amr.corp.intel.com > Cc: Jonathan Corbet > Acked-by: Randy Dunlap > Acked-by: Dave Airlie > Acked-by: Kees Cook > Acked-by: SeongJae Park > Signed-off-by: Olof Johansson > Signed-off-by: Chris Mason > Signed-off-by: Greg Kroah-Hartman > Signed-off-by: Dan Williams > --- > Changes since v1 [1] > - Drop inclusive-terminology.rst, it is in the lore archives if the > arguments are needed for future debates, but otherwise no pressing > need to carry it in the tree (Linus, James) > > - Update the recommended terms to include replacement for 'master' and > 'whitelist' (Kees, Andy) > > - Add 'target' as a replacement (Andy) > > - Add 'device' as a replacement (Mark) > > - Collect acks and signed-off-bys. Yes, the sign-offs are not reflective > of a submission chain, but I kept "Signed-off-by" if people offered > it. In that case, I will "upgrade" my Ack. ;) Signed-off-by: Kees Cook :) > - Non-change: I did not add explicit language as to what to do with > existing usages. My personal inclination is to prioritize this > coding-style cleanup higher than others, but the coding-style document > has typically not indicated policy on how cleanups are handled by > subsystems. It will be a case by case effort and consideration. While I'd like to have published guidance on fixing existing language (which is already underway[1]), I agree: let's start here. > [...] > +For symbol names, avoid introducing new usage of 'master/slave' (or For symbol names, comments, documentation, and other language, avoid introducing ... > +'slave' independent of 'master') and 'blacklist/whitelist'. Recommended > +replacements for 'master/slave' are: 'main/{secondary,subordinate}', > +'primary/replica', '{initiator,requester}/{target,responder}', the main and primary should be merged, IMO: '{primary,main}/{secondary,replica,subordinate}' > +'host/{device,proxy}', or 'leader/{performer,follower}'. Recommended leader/performer does not track for me. Split it out? 'leader/follower', 'director/performer' I have also seen: 'controller/worker' Thanks! -Kees [1] https://lore.kernel.org/lkml/20200630174123.GA1906678@kroah.com/ https://lore.kernel.org/lkml/20200701171555.3198836-1-gregkh@linuxfoundation.org/ -- Kees Cook