From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BEA904D9E8 for ; Mon, 11 Mar 2024 16:04:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710173050; cv=none; b=omHzlkDUrEePa2NJ5aoWilgzf+XCL7SEwh4tUCm61Gahc3IZrs8fKqiNPxHDxgfV4nqs8YqfFa9n5Q3r8wcNIb1wyN7M0HzoUq47Z8tlBwtdUCLy3GyWLy2uO8JDX2+j7gob9qDVL8IOhlCRDcLZnfo13lnPNfpmo0LkfGWPtNM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710173050; c=relaxed/simple; bh=eAF47USsvl6GvU6CcbuiuNsY6BM5J/F4iddiICFuahI=; h=Content-Type:Mime-Version:Date:Message-Id:Cc:Subject:From:To: References:In-Reply-To; b=CLqfxQlZbtHgAupXE7R+q2LHqBZX1FsOaXBYqn7I5VUlQ6HUkC6SKTndkltYmytOJYGbhhAvl3IiModJuJtgHaHsPf3zUKgoAJWesmzL3JSlV5NHhGXAF3ic9KtYv4cIe9t2YjTIm3OBMepdbru3wMusxjlxtwE2pD1CG2DnrVM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dvWe7m9z; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dvWe7m9z" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5684ea117a3so2875859a12.0 for ; Mon, 11 Mar 2024 09:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710173047; x=1710777847; darn=lists.linux.dev; h=in-reply-to:references:to:from:subject:cc:message-id:date :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cvFf2k0hLdwTCSIUw1b2M4KOaEGLFXLzuaUdA5ebJIk=; b=dvWe7m9zD/nVjWXiLuyWu07tx8byaVhD9bb+AYP0Zg8EMczXl1hDX5wbUhcNGGXeH7 8b/SX284xF9yaHcvLMbO705VXo1hoNtwBLT5xLj3VAJqchGXo++932McBUrFDGix4K9A BzOsdxCsLzOABIB2Xh5x/b+YwhNOAkpuRmu8RPr8nI0qRMRAxhJJranJU0FqwMTcu2MF K9HDzB9ebwVG/Vz6frVm/cOt2tSiVvUBQRGnCCLNlF9+rudceijZSbV2ud+l/t9eCHhX 3fD7VoM/+pBMR+uFsoccw2YMXZ0P+43XVY1ylY61+ulj7sNZfRwUM8Jjgwn+Ho/OwQMx ZHIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710173047; x=1710777847; h=in-reply-to:references:to:from:subject:cc:message-id:date :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cvFf2k0hLdwTCSIUw1b2M4KOaEGLFXLzuaUdA5ebJIk=; b=CX1Nc/0D13uXHRfeOPOWVHVJmgRhxzKdJoJwyE9DqgB/Wd0yHmqruXzTx5IPS1kzTn Cbjhwjmzqut92YrT3Lv0hVL63FuppHnkv4BhYA1lowA/ONH4hd2LGGiyuK/b6GOVoYuz q0T3LauabBb3+AIfYYEAV/zwbf+Uzjq1Lo219LfFVMPA4NMR0HysXHSdH06lOeKqxvb6 1KHRIzgVeAfdnQeDEPjSuj9eRKq+OYdeaMduzRL+lujueJbm5Oiy3C+hIiraLidpCEJt Latx/ahZsrHO7SPP1XQraeoo3NjIFedP45hl0HWhoyBI6RjLD3ToZ34aHaQxFXPPVBjO Gopg== X-Forwarded-Encrypted: i=1; AJvYcCWJI/GCr7fooMvXyLrU43Ewr8852+oBNSEli3QmJEESql2fSi93jhA1SDGarcJHbJ2uQ23ZZJUpn9VXK+76EC6hdviU/Ifou39C X-Gm-Message-State: AOJu0YyRY2F7pNHf2EFAFSUrmGREGpmJNA5rhqdYKhxj9PU+kciuq95H oCw75Wz3sPegLCg84Pzu15Pin+Kdpw53srZ5tT60criebWhsLoch X-Google-Smtp-Source: AGHT+IF3/wqnxno1PQ5O/Un7JaS4AMZcCQLtv0MunU2CN2KzLO75PZEjJhGMu4csFW2tBl37PcI+jA== X-Received: by 2002:a50:cd15:0:b0:566:16e4:b6b3 with SMTP id z21-20020a50cd15000000b0056616e4b6b3mr4253238edi.36.1710173046751; Mon, 11 Mar 2024 09:04:06 -0700 (PDT) Received: from localhost (p200300e41f162000f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f16:2000:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id s20-20020a05640217d400b00566ea8e9f38sm3033913edy.40.2024.03.11.09.04.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 Mar 2024 09:04:06 -0700 (PDT) Content-Type: multipart/signed; boundary=a67836c0427bcb0ce7e2976400776a51e382e07418ed8532f736485bec42; micalg=pgp-sha256; protocol="application/pgp-signature" Precedence: bulk X-Mailing-List: timestamp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Date: Mon, 11 Mar 2024 17:04:05 +0100 Message-Id: Cc: "Jonathan Hunter" , , , Subject: Re: [PATCH] hte: tegra-194: Convert to platform remove callback returning void From: "Thierry Reding" To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , "Dipen Patel" X-Mailer: aerc 0.16.0-1-0-g560d6168f0ed-dirty References: <0b0a5d3816973ee88d4be9fe9f2349065a42cbff.1709886922.git.u.kleine-koenig@pengutronix.de> In-Reply-To: <0b0a5d3816973ee88d4be9fe9f2349065a42cbff.1709886922.git.u.kleine-koenig@pengutronix.de> --a67836c0427bcb0ce7e2976400776a51e382e07418ed8532f736485bec42 Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 On Fri Mar 8, 2024 at 9:51 AM CET, Uwe Kleine-K=C3=B6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-K=C3=B6nig > --- > drivers/hte/hte-tegra194-test.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Acked-by: Thierry Reding --a67836c0427bcb0ce7e2976400776a51e382e07418ed8532f736485bec42 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmXvK3YACgkQ3SOs138+ s6HfcRAAo1TclDTpQAvLx8p+fqtLLph42rATzcRewTFPKzcvFVtSqgrJApanWri2 a+7Wx2QHOxA+Xrq/7z07ILjxbobztUFlQ4HN0/vhz1iUmhPcwJc7gyQhO7i80D/z 5Jb1uLd4jtSvEl8BJ5x3+vdDKcQDY33kwC0IMeniBrEBkw/G8vONNFyjHqU4xjh9 H5VvStZd/yxwd4ZlNGFI1PFBmtOtdZ8x6WPVQDuoHAj+AdwtTgA1t35NHlET+RtZ OHflL4fl6xlDm94/CpbM0Lxp7ynpGROMitbvx0AVh5V+sQFl4WXWlDDWuOSkiZd7 fgP6ysDO+7CdbRLw3QYtSW4DbRLFoIw3SdLIT379sziWN6vlEAjDt2JuvCuMNrj0 8pcOQhShvJO4B+rz/OO6fHuUrdcqEcIAsWxCfzJDyiJv1IrjSuQc+WB/m6fN/P2N bsPaxZkk3PBpcfniVUMw4x9IuKgtaD8SBgzH2/UWkfOqQ4xPZ1isV3y92jAbTOsH cSwGra5i6z997nvCpe2uCXOy5j+ZHSUdkbj9SLOUz9QxsRDJ9+2wrC0alQKcB0Uj a99szkJNlCUoLvWNeP/Sk5v8UaqsLoc8YNWiriu446Bee4lA6+IAhPntWsRuJtnt PXwBbOFS35c+zdA9Gh8OMb8iQiBrIiDs88willhGP4mQd1ull1M= =c35F -----END PGP SIGNATURE----- --a67836c0427bcb0ce7e2976400776a51e382e07418ed8532f736485bec42--