From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dipen Patel <dipenp@nvidia.com>
Cc: timestamp@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/1] hte: Use kasprintf() instead of fixed buffer formatting
Date: Fri, 27 Oct 2023 15:39:42 +0300 [thread overview]
Message-ID: <ZTuvjqYXxWPyHrVR@smile.fi.intel.com> (raw)
In-Reply-To: <59939570-3779-ef90-2a72-7be32a30e368@nvidia.com>
On Tue, Oct 10, 2023 at 09:12:09AM -0700, Dipen Patel wrote:
> On 10/10/23 7:11 AM, Andy Shevchenko wrote:
> > Improve readability and maintainability by replacing a hardcoded string
> > allocation and formatting by the use of the kasprintf() helper.
...
> > hte_ts_dbgfs_init(desc->attr.name == NULL ?
> > ei->line_name : desc->attr.name, ei);
> Reviewed-by: Dipen Patel <dipenp@nvidia.com>
Thanks!
Who is the maintainer of this code?
If not you, shouldn't MAINTAINERS to be updated to reflect that?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-27 12:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 14:11 [PATCH v1 1/1] hte: Use kasprintf() instead of fixed buffer formatting Andy Shevchenko
2023-10-10 16:12 ` Dipen Patel
2023-10-27 12:39 ` Andy Shevchenko [this message]
2023-10-27 21:03 ` Dipen Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTuvjqYXxWPyHrVR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dipenp@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=timestamp@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).