From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3D4320EE for ; Sat, 25 Mar 2023 11:05:57 +0000 (UTC) Received: by mail-ed1-f45.google.com with SMTP id h8so17301717ede.8 for ; Sat, 25 Mar 2023 04:05:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679742356; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HJ+YX1Je9jtZyNwMQVxLzTWCIOluw4CEQGsvPNKY5WI=; b=tm+5zepFGWyCmvXiEylO9foN9td4HN3bv6rnc455QiCc+x5PSQZlfGFCQwKdUsOlIx fBJxjTJkDAoNqjXeqE3AVjgkfEcYbpyibqSraS+p+E8bnZIvd3LIOC9RGlcQbVhCNIM0 q36RMwnyF4Jvi3zLIxd3RUVzH4+6GYmKLdGqRFXuY6PVgIFfdDLq1tvD686lJe5K52O7 T0ySShjABhOIGYRZgyAa7JWOuT5lMEyDFW5n0lvYBNqJAFZol8ATJq3tUfFZLWDP6d9q FEeSGTZy2JMkbIrH/ukq4R0zY0qMEaOwCfuMaPyTJ+dbUNeztqgnLAVhJ68Sxw9N6aD2 eHpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679742356; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HJ+YX1Je9jtZyNwMQVxLzTWCIOluw4CEQGsvPNKY5WI=; b=I2l5hd4RMBh2At9ulG1e3oO14pkjpr7SBH8KGYMhNWu5Un2R/HUjcLz4yM62gLTy/M G8LnbmJL5gDHQd9EeKIrJ3HiA9zL5UeImUqfMG5v0dTtQoAxmJkrhK0QV6jfuyj96TKt LBl4Qj6hEQvYuNVkv5MrElB79GdhgzFGLa4QiR98/HbdlNZ7LldqB763PZXjxUHnEYIs evebU9dbp3vK+Edja2bgEmorHPH4nfY0c8nMecOLEE9dlRCtlRK88v8L+JRW0KV/+zUP kxUHDDQONN3Fk44LFqFW5YiW/qOAxESbFs5oZ5hVR1n2gEHPhP068bfflANCDlk/JjyX ImZg== X-Gm-Message-State: AAQBX9cVeOj7keQzpqArWpxUfcEXQLoSIzsLWjg80e+xYLWV9idQeUGT 1+BLvbVAWqH2zVFarDDxiRaV/g== X-Google-Smtp-Source: AKy350YtYsV4Es3QVxy9lpHK5fF3wdRNZ9JHftvd4hqtZydp6ueYOugBU+zB3XVfAhi1fRq+giYMzg== X-Received: by 2002:a17:906:2f96:b0:932:8cd:1021 with SMTP id w22-20020a1709062f9600b0093208cd1021mr5439137eji.33.1679742355974; Sat, 25 Mar 2023 04:05:55 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d230:b2c7:d55:c9c8? ([2a02:810d:15c0:828:d230:b2c7:d55:c9c8]) by smtp.gmail.com with ESMTPSA id u6-20020a50d506000000b004fd2aab4953sm12120437edi.45.2023.03.25.04.05.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 04:05:55 -0700 (PDT) Message-ID: Date: Sat, 25 Mar 2023 12:05:53 +0100 Precedence: bulk X-Mailing-List: timestamp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH V4 03/10] dt-bindings: timestamp: Deprecate nvidia,slices property Content-Language: en-US To: Dipen Patel , thierry.reding@gmail.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org, linus.walleij@linaro.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, robh+dt@kernel.org, timestamp@lists.linux.dev, krzysztof.kozlowski+dt@linaro.org, brgl@bgdev.pl, corbet@lwn.net, gregkh@linuxfoundation.org References: <20230323012929.10815-1-dipenp@nvidia.com> <20230323012929.10815-4-dipenp@nvidia.com> From: Krzysztof Kozlowski In-Reply-To: <20230323012929.10815-4-dipenp@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 23/03/2023 02:29, Dipen Patel wrote: > The property is not necessary as it is a constant value and can be > hardcoded in the driver code. > > Signed-off-by: Dipen Patel > --- > .../timestamp/nvidia,tegra194-hte.yaml | 43 ++----------------- > 1 file changed, 4 insertions(+), 39 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml > index 158dbe58c49f..eafc33e9ae2e 100644 > --- a/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml > +++ b/Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml > @@ -42,10 +42,13 @@ properties: > > nvidia,slices: > $ref: /schemas/types.yaml#/definitions/uint32 > + deprecated: true > description: > HTE lines are arranged in 32 bit slice where each bit represents different > line/signal that it can enable/configure for the timestamp. It is u32 > - property and the value depends on the HTE instance in the chip. > + property and the value depends on the HTE instance in the chip. The AON > + GTE instances for both Tegra194 and Tegra234 has 3 slices. The Tegra194 > + LIC instance has 11 slices and Tegra234 LIC has 17 slices. > enum: [3, 11, 17] > > '#timestamp-cells': > @@ -56,46 +59,10 @@ properties: > mentioned in the nvidia GPIO device tree binding document. > const: 1 > > -allOf: > - - if: > - properties: > - compatible: > - contains: > - enum: > - - nvidia,tegra194-gte-aon > - - nvidia,tegra234-gte-aon > - then: > - properties: > - nvidia,slices: > - const: 3 > - > - - if: > - properties: > - compatible: > - contains: > - enum: > - - nvidia,tegra194-gte-lic > - then: > - properties: > - nvidia,slices: > - const: 11 > - > - - if: > - properties: > - compatible: > - contains: > - enum: > - - nvidia,tegra234-gte-lic > - then: > - properties: > - nvidia,slices: > - const: 17 You just added this entire block in previous patch. Adding it there and immediately removing does not make much sense. > - Best regards, Krzysztof