From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: "Kernel.org Tools" <tools@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Tomas Melin <tomas.melin@vaisala.com>
Subject: Re: [PATCH b4 1/2] ez: add SMTP authentication method to printed information
Date: Sun, 01 Feb 2026 00:37:34 -0500 [thread overview]
Message-ID: <176992425474.611611.3433768227265573567@lemur> (raw)
In-Reply-To: <20260129-smtp-oauth2-outlook-v1-1-e8c6d1b00c03@vaisala.com>
On Thu, 29 Jan 2026 11:10:29 +0200, Tomas Melin <tomas.melin@vaisala.com> wrote:
> diff --git a/src/b4/ez.py b/src/b4/ez.py
> index 298e382..581d513 100644
> --- a/src/b4/ez.py
> +++ b/src/b4/ez.py
> @@ -2193,7 +2193,7 @@ def cmd_send(cmdargs: argparse.Namespace) -> None:
> sys.exit(1)
>
> else:
> - logger.info(' - via SMTP server %s', smtpserver)
> + logger.info(' - via SMTP server %s using %s auth', smtpserver, sconfig.get('smtpauth', 'basic'))
>
This is a nit, but the default value 'basic' is displayed when smtpauth is not
configured, but the actual auth mechanism used by get_smtp() is login-based
(smtp.login()), not "basic". Consider 'login' as a more accurate default label,
or only display the auth method when smtpauth is explicitly set.
> if not (cmdargs.reflect or cmdargs.resend or cmdargs.preview_to):
> logger.info(' - tag and reroll the series to the next revision')
--
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
next prev parent reply other threads:[~2026-02-01 5:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 9:10 [PATCH b4 0/2] Add support for oauth2 SMTP authentication Tomas Melin
2026-01-29 9:10 ` [PATCH b4 1/2] ez: add SMTP authentication method to printed information Tomas Melin
2026-02-01 5:37 ` Konstantin Ryabitsev [this message]
2026-02-02 14:31 ` Tomas Melin
2026-01-29 9:10 ` [PATCH b4 2/2] b4: add support for oauth2 SMTP authentication Tomas Melin
2026-01-30 12:09 ` Tomas Melin
2026-02-01 5:37 ` Konstantin Ryabitsev
2026-02-02 14:08 ` Tomas Melin
2026-02-02 16:49 ` Tomas Melin
2026-02-03 3:31 ` Konstantin Ryabitsev
2026-02-01 5:37 ` [PATCH b4 0/2] Add " Konstantin Ryabitsev
2026-02-01 5:52 ` Konstantin Ryabitsev
2026-02-05 9:18 ` Tomas Melin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176992425474.611611.3433768227265573567@lemur \
--to=konstantin@linuxfoundation.org \
--cc=tomas.melin@vaisala.com \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox