tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Jason Gunthorpe" <jgg@ziepe.ca>
To: tools@linux.kernel.org
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Link: headers and %?
Date: Tue, 14 Apr 2020 20:20:00 -0300	[thread overview]
Message-ID: <20200414232000.GA10393@ziepe.ca> (raw)

I'm not quite sure where to post this, but since it intersects with
lore.kernel.org, this seems like a reasonable place.

Many people have been using the Link: headers lately, yay, but I've
noticed that some message ID's have a % in them, and people who have
scripts generating Link happily create commits like this:

commit 3baf89abca196f6dcb7038fd5342fd6e82f3260c
[..]
    Link: https://lore.kernel.org/r/20200324022505.UiPPJZVXX%akpm@linux-foundation.org

But the URLs don't work. They give a 404 because the % is the URL
escape character. To make the URL work it should be changed to %25:

https://lore.kernel.org/r/20200324022505.UiPPJZVXX%25akpm@linux-foundation.org

This situation seems sub-optimal.

It actually seems we have a mixture as some people must already be
using scripts that solve this:

commit 060dc911501f6ee222569304f50962172a52b1d6
    Link: https://lore.kernel.org/lkml/201912212139.yptX8CsV%25lkp@intel.com/

Should we URL encode the Link headers when creating the commits, or
should lore somehow not un-escape /r/ paths? They seem like exclusive
options.

Maybe checkpatch should be complaining?

Jason

                 reply	other threads:[~2020-04-14 23:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200414232000.GA10393@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).