Re: b4 ty feature requests

["Mark Brown" <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2078 bytes --]

On Fri, Apr 17, 2020 at 12:14:24PM -0400, Konstantin Ryabitsev wrote:
> On Fri, Apr 17, 2020 at 04:44:30PM +0100, Mark Brown wrote:

> > One thing that would be nice would be mechanism to supply some
> > additional values to be filled in the templates - I want to be able to
> > tell people what tree and branch I applied things to.  A command line
> > option to set the templates might also work but would be clunkier for
> > me.

> Branch would be easy, e.g.:

> ---
> Applied to ${branch}, thanks!
> ---

> I'm not sure how to convey the tree information. Would it be a sane 
> approach to try to use current dirname as default, overridable via a 
> b4.thanks-tree-name value? E.g.:

> ---
> Applied to ${treename} ${branch} branch, thanks!
> ---

That wouldn't work well for me since I have a single repo with multiple
remotes - I'm invoking b4 as:

	b4 ty -b remote/branch -a

so I'd need to switch out the config file to update the variable for the
tree name and the branch name would I think come out wrong.  People
probably would mostly understand the short names I use for my remotes so
it wouldn't be the end of the world to just say ${branch} and have it
show up as remote/branch but I know inexperienced contributors sometimes
find figuring out exactly which tree you mean a bit confusing so the URL
is useful for them.

In that particular usage b4 could parse out the fact that it's a remote
based on asking git-remote if the thing before the first / is a remote
and use the info from that to rewrite such that the branch gets expanded
into a GIT URL plus branch but that may be a bit too much DWIM.  You'd
get something like

	b4 ty -b asoc/for-5.8 -a

with a template of

	Applied to ${branch}

generating

	Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.8

TBH I'd personally be happy just specifying variables I name on the
command line (the actual b4 invocation is scripted for me) and that's
what I'd been imagining, although something more fancy would be very
nice.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 499 bytes --]