From: alison.schofield@intel.com
To: tools@linux.kernel.org
Cc: Alison Schofield <alison.schofield@intel.com>
Subject: [PATCH b4] Avoid case where message-id and in-reply-to id match
Date: Wed, 15 Mar 2023 22:55:23 -0700 [thread overview]
Message-ID: <20230316055523.728335-1-alison.schofield@intel.com> (raw)
From: Alison Schofield <alison.schofield@intel.com>
A user error while sending a patchset created a lore link that b4 is
not able to handle. The unexpected matching message-id and in-reply-to
id sends b4 into an infinite loop while 'Analyzing follow-up'.
Add a check and break for this case.
b4 am -c https://lore.kernel.org/all/cover.1674070170.git.alison.schofield@intel.com/
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
---
Not so sure this is the first place that b4 can and should detect this.
b4/__init__.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/b4/__init__.py b/b4/__init__.py
index 94c1693..4ed8ad8 100644
--- a/b4/__init__.py
+++ b/b4/__init__.py
@@ -333,6 +333,9 @@ class LoreMailbox:
pmsg.followup_trailers += trailers
break
if pmsg.in_reply_to and pmsg.in_reply_to in self.msgid_map:
+ # Avoid bad message id causing infinite loop
+ if pmsg == self.msgid_map[pmsg.in_reply_to]:
+ break
lvl += 1
for pltr in pmsg.trailers:
pltr.lmsg = pmsg
base-commit: 2eb1ab30a6a6f6b140f19ef36b5af7f73f000720
--
2.37.3
next reply other threads:[~2023-03-16 5:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 5:55 alison.schofield [this message]
2023-03-17 13:58 ` [PATCH b4] Avoid case where message-id and in-reply-to id match Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316055523.728335-1-alison.schofield@intel.com \
--to=alison.schofield@intel.com \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox