b4 trailers --update splats on new branch

b4 trailers --update splats on new branch

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1114 bytes --]

Hi Konstantin,

If I run b4 trailers --update with current master on a series which I've
not sent yet (which I do as part of my testing for outbound serieses
just to make sure I didn't miss anything) then b4 gets upset and prints
a Python backtrace:

Calculating patch-ids from commits, this may take a moment...
Checking change-id "20230303-arm64-cpufeature-helpers-a70213a244e7"
Grabbing search results from lore.kernel.org
Traceback (most recent call last):
  File "/home/broonie/git/b4/b4/command.py", line 381, in <module>
    cmd()
  File "/home/broonie/git/b4/b4/command.py", line 364, in cmd
    cmdargs.func(cmdargs)
  File "/home/broonie/git/b4/b4/command.py", line 81, in cmd_trailers
    b4.ez.cmd_trailers(cmdargs)
  File "/home/broonie/git/b4/b4/ez.py", line 2201, in cmd_trailers
    update_trailers(cmdargs)
  File "/home/broonie/git/b4/b4/ez.py", line 890, in update_trailers
    addtrailers = list(lmsg.followup_trailers)
AttributeError: 'NoneType' object has no attribute 'followup_trailers'

This seems like it should at least print a nicer error, and I'm sure
this used to work.

Thanks,
Mark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: b4 trailers --update splats on new branch

[Konstantin Ryabitsev]

On Wed, Apr 12, 2023 at 06:23:10PM +0100, Mark Brown wrote:
> This seems like it should at least print a nicer error, and I'm sure
> this used to work.

Thanks for the report.

bugbot assign to me

-K

Re: b4 trailers --update splats on new branch

[Kernel.org Bugbot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=217331

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

Re: b4 trailers --update splats on new branch

[Kernel.org Bugbot]

Konstantin Ryabitsev writes in commit 00e423af1a0968f2f90a4c3384c202ffee98bc08:

ez-trailers: don't crash when there are no follow-ups received

If there are no follow-up trailers to process, bail early as opposed to
crashing.

Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217331
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=00e423af1a09)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

Re: b4 trailers --update splats on new branch

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 324 bytes --]

On Wed, Apr 19, 2023 at 05:38:09PM +0000, Kernel.org Bugbot wrote:
> Konstantin Ryabitsev writes in commit 00e423af1a0968f2f90a4c3384c202ffee98bc08:
> 
> ez-trailers: don't crash when there are no follow-ups received
> 
> If there are no follow-up trailers to process, bail early as opposed to
> crashing.

Thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: b4 trailers --update splats on new branch

[Kernel.org Bugbot]

Konstantin Ryabitsev writes in commit bfdf5b3b0835c8c351abbcd9b3b5268acf6545fa:

ez: better fix for "no follow-up trailers" condition

Previous fix for bug 217331 didn't properly handle the situation when
trailers were sent to the cover letter, so implement a better fix.

Fixes: 00e423af1a (ez-trailers: don't crash when there are no follow-ups received)
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217331
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=bfdf5b3b0835)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)