Unhelpful cover letter default for single patch serieses

Unhelpful cover letter default for single patch serieses

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 945 bytes --]

Hi,

When creating single patch serieses I repeately get tripped up by the
default cover letter behaviour with EDITME.  I run

	b4 prep <make a new branch>
	<make kernel do thing>
	b4 prep --auto-to-cc

see that --auto-to-cc did what I wanted then run my CI only to have b4
send fail afterwards due to the EDITMEs left in the cover letter which I
never saw since I don't want a cover for a single patch series and
--auto-to-cc did the right thing.

Perhaps this could be addressed by both changing the default cover
letter to not include the EDITMEs and switching the sense of the check
so that b4 send requires some magic string in the cover letter to send a
blank cover letter for a multi-patch series (NOCOVER or something)?
That'd mean that people would get no cover letter for single patch
serieses without any friction but still refuse to send a multi-patch
series without a cover letter unless the user actively intervenes.

Thanks,
Mark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Unhelpful cover letter default for single patch serieses

[Konstantin Ryabitsev]

On Fri, Apr 28, 2023 at 07:32:06PM +0100, Mark Brown wrote:
> When creating single patch serieses I repeately get tripped up by the
> default cover letter behaviour with EDITME.  I run
> 
> 	b4 prep <make a new branch>
> 	<make kernel do thing>
> 	b4 prep --auto-to-cc
> 
> see that --auto-to-cc did what I wanted then run my CI only to have b4
> send fail afterwards due to the EDITMEs left in the cover letter which I
> never saw since I don't want a cover for a single patch series and
> --auto-to-cc did the right thing.

I'll think of something for single-patch series.

bugbot assign to me

-K

Re: Unhelpful cover letter default for single patch serieses

[Kernel.org Bugbot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=217388

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

Re: Unhelpful cover letter default for single patch serieses

[Kernel.org Bugbot]

Konstantin Ryabitsev writes in commit cb93cd00e391622db4a49753f8944ce2b29c5d9d:

ez: make it easier to send single-patch series

Do not force developers to edit the cover letter when information from
it is not going to be included into the single-patch message anyway.

Suggested-by: Mark Brown <broonie@kernel.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217388
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=cb93cd00e391)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)