tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
* [BUG b4] resending drops previously configured prefixes
@ 2023-06-16  7:11 Erik Schilling
  2023-06-16 16:54 ` Konstantin Ryabitsev
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Erik Schilling @ 2023-06-16  7:11 UTC (permalink / raw)
  To: tools

If I sent the original series with a prefix, then resend will send
with [PATCH RESEND] but will no longer contain the original prefix.

I am not sure how one would fix it the best way, it looks like prefixes
are not tracked as part of the history. Maybe they should? I might drop
a WIP but still want to be able to reproduce a past version... But maybe
it would also just be enough to resend with the currently configured
prefix (+ RESEND)?

- Erik

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [BUG b4] resending drops previously configured prefixes
  2023-06-16  7:11 [BUG b4] resending drops previously configured prefixes Erik Schilling
@ 2023-06-16 16:54 ` Konstantin Ryabitsev
  2023-06-16 17:00 ` Kernel.org Bugbot
  2023-06-23 17:15 ` Kernel.org Bugbot
  2 siblings, 0 replies; 4+ messages in thread
From: Konstantin Ryabitsev @ 2023-06-16 16:54 UTC (permalink / raw)
  To: Erik Schilling; +Cc: tools

On Fri, Jun 16, 2023 at 09:11:35AM +0200, Erik Schilling wrote:
> If I sent the original series with a prefix, then resend will send
> with [PATCH RESEND] but will no longer contain the original prefix.
> 
> I am not sure how one would fix it the best way, it looks like prefixes
> are not tracked as part of the history. Maybe they should? I might drop
> a WIP but still want to be able to reproduce a past version... But maybe
> it would also just be enough to resend with the currently configured
> prefix (+ RESEND)?

I'll check and make sure that we always send the latest configured prefixes.

bugbot assign to me

-K

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: resending drops previously configured prefixes
  2023-06-16  7:11 [BUG b4] resending drops previously configured prefixes Erik Schilling
  2023-06-16 16:54 ` Konstantin Ryabitsev
@ 2023-06-16 17:00 ` Kernel.org Bugbot
  2023-06-23 17:15 ` Kernel.org Bugbot
  2 siblings, 0 replies; 4+ messages in thread
From: Kernel.org Bugbot @ 2023-06-16 17:00 UTC (permalink / raw)
  To: erik.schilling, tools

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=217564

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: resending drops previously configured prefixes
  2023-06-16  7:11 [BUG b4] resending drops previously configured prefixes Erik Schilling
  2023-06-16 16:54 ` Konstantin Ryabitsev
  2023-06-16 17:00 ` Kernel.org Bugbot
@ 2023-06-23 17:15 ` Kernel.org Bugbot
  2 siblings, 0 replies; 4+ messages in thread
From: Kernel.org Bugbot @ 2023-06-23 17:15 UTC (permalink / raw)
  To: erik.schilling, konstantin, tools

Konstantin Ryabitsev writes in commit 099c9b47b39b6076752b8c757872080fad8fae56:

ez: store sent prefixes with the tag message

For resend purposes, we need to store the prefixes that were used for
sending that series at the time. This way when --resend is used, we can
restore the subject line to what it was at the time.

Reported-by: Erik Schilling <erik.schilling@linaro.org>
Link: https://msgid.link/CTDVYQ01B09D.1FUED4Y6IQUKI@fedora
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217564
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=099c9b47b39b)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-06-23 17:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-16  7:11 [BUG b4] resending drops previously configured prefixes Erik Schilling
2023-06-16 16:54 ` Konstantin Ryabitsev
2023-06-16 17:00 ` Kernel.org Bugbot
2023-06-23 17:15 ` Kernel.org Bugbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).