Re: [PATCH b4] ez: Add a --web arg to force web endpoint

[Konstantin Ryabitsev <konstantin@linuxfoundation.org>]

On Tue, Aug 01, 2023 at 05:03:36PM +0200, Joel Granados via B4 Relay wrote:
> From: Joel Granados <j.granados@samsung.com>
> 
> Make it easier to prefer going through the web endpoint by adding an
> argument that will force this path. This is for users that want to use
> B4 for preparing and sharing patchsets over mail and need an argument to
> activate the web endpoint whenever needed, but want to default to smtp
> server for the rest.

Okay, that looks good to me, but can you please make two changes:

> @@ -330,6 +330,8 @@ def setup_parser() -> argparse.ArgumentParser:
>                            help='Initiate a new web authentication request')
>      ag_sendh.add_argument('--web-auth-verify', dest='auth_verify', metavar='VERIFY_TOKEN',
>                            help='Submit the token received via verification email')
> +    ag_sendh.add_argument('--web', dest='send_web', action='store_true', default=False,
> +                          help="Force the send command to go through the web endpoint")

1. It doesn't really belong in this argument group (it's just for
   setting up authentication and says so in the title). You can just put this
   switch with the main arguments, perhaps as the last entry.
2. Call it --use-web-endpoint instead of just --web

Thanks!

-K