From: Kees Cook <keescook@chromium.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
"tools@linux.kernel.org" <tools@linux.kernel.org>,
Kalle Valo <kvalo@kernel.org>
Subject: Re: b4 tag parsing too lax?
Date: Thu, 14 Sep 2023 09:55:07 -0700 [thread overview]
Message-ID: <202309140954.3A38E1B14D@keescook> (raw)
In-Reply-To: <ff72f308879a12f53fa7ace044ab99ab7dd9e060.camel@sipsolutions.net>
On Thu, Sep 14, 2023 at 08:55:25AM +0200, Johannes Berg wrote:
> On Wed, 2023-09-13 at 23:04 +0000, Kees Cook wrote:
> > On Wed, Sep 13, 2023 at 04:00:27PM -0400, Konstantin Ryabitsev wrote:
> > > On Wed, Sep 13, 2023 at 12:44:43PM -0700, Kees Cook wrote:
> > > > Hi,
> > > >
> > > > I just saw this in commit ef6e1997da63 ("wifi: mac80211: fortify the
> > > > spinlock against deadlock by interrupt"):
> > > >
> > > > Reviewed-by: tag, or it goes automatically?
>
> Heh, that's kinda funny.
>
> > > While it's possible that b4 did this, it's not any current version.
>
> It didn't.
>
> > Okay, weird! I have no idea how that got there then.
> >
> > I should have CCed Johannes Berg to start with, but now I have. :) I'm
> > curious what the workflow for that patch was -- do you use b4? (Perhaps
> > this was a b4 behavior accidentally back in May?)
> >
>
> We use patchwork in wireless to assign the work between Kalle and I. I
> guess I could still apply patches using b4 though, but don't, at this
> point.
>
> So I guess it's more a bug to report to patchwork, but I'm not sure how
> much good that will do unless we fix it ourselves :)
Ah-ha! Patchwork did the collecting. Thanks for taking a look. :)
-Kees
--
Kees Cook
prev parent reply other threads:[~2023-09-14 16:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-13 19:44 b4 tag parsing too lax? Kees Cook
2023-09-13 20:00 ` Konstantin Ryabitsev
2023-09-13 23:04 ` Kees Cook
2023-09-14 6:55 ` Johannes Berg
2023-09-14 13:44 ` Konstantin Ryabitsev
2023-09-14 16:55 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202309140954.3A38E1B14D@keescook \
--to=keescook@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=konstantin@linuxfoundation.org \
--cc=kvalo@kernel.org \
--cc=tools@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox