Re: [PATCH RESEND v4 0/3] livepatch: Move modules to selftests and add a new test

Re: [PATCH RESEND v4 0/3] livepatch: Move modules to selftests and add a new test

[Konstantin Ryabitsev]

On Thu, Dec 21, 2023 at 09:17:04AM -0300, Marcos Paulo de Souza wrote:
> To clarify: this is not a resend, this is the v4 that people were
> waiting for. I made a mistake with b4 tool, that first I sent the email
> just to myself, for testing, and it bumped the version to v5, but I
> asked it to "resend" the v4, but it ended up adding the "RESEND" to the
> series.

Thank you for sharing that. The expected workflow here would be to use
--reflect first if you wanted to send something to yourself. Can you think of
a way that this experience can be less unexpected?

(Dropping everyone else from cc's and adding the tools list)

-K

Re: [PATCH RESEND v4 0/3] livepatch: Move modules to selftests and add a new test

[Marcos Paulo de Souza]

On Fri, 2023-12-22 at 13:40 -0500, Konstantin Ryabitsev wrote:
> On Thu, Dec 21, 2023 at 09:17:04AM -0300, Marcos Paulo de Souza
> wrote:
> > To clarify: this is not a resend, this is the v4 that people were
> > waiting for. I made a mistake with b4 tool, that first I sent the
> > email
> > just to myself, for testing, and it bumped the version to v5, but I
> > asked it to "resend" the v4, but it ended up adding the "RESEND" to
> > the
> > series.
> 
> Thank you for sharing that. The expected workflow here would be to
> use
> --reflect first if you wanted to send something to yourself. Can you
> think of
> a way that this experience can be less unexpected?

So my usecase was that I first sent the patches locally to my
colleagues, so I used
	b4 send --no-trailer-to-cc --to
colleague1@suse.com,colleague2@suse.com

Well, maybe adding a confirmation for the user that the version will be
bumped. A new flag could also be created b4 send --keep-version to send
without bumping, thus avoiding the prompt?

Is this too convoluted?

Thanks!
  Marcos

> 
> (Dropping everyone else from cc's and adding the tools list)
> 
> -K

Re: [PATCH RESEND v4 0/3] livepatch: Move modules to selftests and add a new test

[Konstantin Ryabitsev]

On Fri, Dec 22, 2023 at 03:52:29PM -0300, Marcos Paulo de Souza wrote:
> So my usecase was that I first sent the patches locally to my
> colleagues, so I used
> 	b4 send --no-trailer-to-cc --to
> colleague1@suse.com,colleague2@suse.com
> 
> Well, maybe adding a confirmation for the user that the version will be
> bumped. A new flag could also be created b4 send --keep-version to send
> without bumping, thus avoiding the prompt?
> 
> Is this too convoluted?

No, this sounds reasonable -- we do need to support a "hey, can you look over
this pretty quick" kind of action.

How about the following:

    b4 send --only-to colleague1@example.com,colleague2@example.com

This will automatically trigger the "don't tag and reroll" mode.

-K

Re: [PATCH RESEND v4 0/3] livepatch: Move modules to selftests and add a new test

[Marcos Paulo de Souza]

On Fri, 2023-12-22 at 14:11 -0500, Konstantin Ryabitsev wrote:
> On Fri, Dec 22, 2023 at 03:52:29PM -0300, Marcos Paulo de Souza
> wrote:
> > So my usecase was that I first sent the patches locally to my
> > colleagues, so I used
> > 	b4 send --no-trailer-to-cc --to
> > colleague1@suse.com,colleague2@suse.com
> > 
> > Well, maybe adding a confirmation for the user that the version
> > will be
> > bumped. A new flag could also be created b4 send --keep-version to
> > send
> > without bumping, thus avoiding the prompt?
> > 
> > Is this too convoluted?
> 
> No, this sounds reasonable -- we do need to support a "hey, can you
> look over
> this pretty quick" kind of action.
> 
> How about the following:
> 
>     b4 send --only-to colleague1@example.com,colleague2@example.com
> 
> This will automatically trigger the "don't tag and reroll" mode.

Looks great! Exactly what I wanted to do, and very simple. Thanks a lot
for looking into it!

> 
> -K

Re: [PATCH RESEND v4 0/3] livepatch: Move modules to selftests and add a new test

[Konstantin Ryabitsev]

On Fri, Dec 22, 2023 at 04:13:40PM -0300, Marcos Paulo de Souza wrote:
> > How about the following:
> > 
> >     b4 send --only-to colleague1@example.com,colleague2@example.com
> > 
> > This will automatically trigger the "don't tag and reroll" mode.
> 
> Looks great! Exactly what I wanted to do, and very simple. Thanks a lot
> for looking into it!

I'm going to implement it as --dry-run-to, just to make it more obvious that
it's a dry-run action and won't trigger a tag-and-reroll.

So, you should be able to do:

    b4 send --dry-run-to mentor1@example.com mentor2@example.com

The subject line prefixes will also include DRYRUN in that case, e.g.:

    [PATCH DRYRUN 0/3] Some cover title

-K

bugbot assign to me

Re: [PATCH RESEND v4 0/3] livepatch: Move modules to selftests and add a new test

[Kernel.org Bugbot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=218302

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

Re: b4: implement send --dry-run-to ADDR [ADDR ...]

[Kernel.org Bugbot]

Konstantin Ryabitsev writes in commit 4e03211130d5afbf26297bee8b549013fc30e6fc:

ez: implement send --dry-run-to

Sometimes it is useful to be able to send the series out to someone for
a quick one-over review (e.g. to your mentor, boss, colleague) before
actually sending it out to the actual maintainers.

It is now possible to do so with:

    b4 send --dry-run-to addr@example.com

This will not trigger a tag-and-reroll and will include a DRYRUN into
the patch prefixes to clearly indicate that it's not the final
submission that should be used for review.

Suggested-by: Marcos Paulo de Souza <mpdesouza@suse.com>
Link: https://lore.kernel.org/f5c38763b4d42cfafdaac24d83ec18b81dfc073a.camel@suse.com
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218302
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=4e03211130d5)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)