Re: [PATCH b4 v2] b4: add shell completion via python-shtab

[Konstantin Ryabitsev <konstantin@linuxfoundation.org>]

On Wed, Mar 06, 2024 at 12:03:31PM +0000, Emil Velikov wrote:
> > My preference would be to go this route, because it doesn't create a new
> > dependency on shtab but still lets packagers generate and ship the
> > tab-completion content.
> >
> 
> The above solution can break in a number of cases and since there's no
> CI, it can lurk broken for a while.

Yes, but the same is true for any number of other things. Since this is an
auxiliary feature, it's not really critical in my view.

> - path changes from src/b4/ to ...

I doubt this will change again -- I just did this as a large breaking feature
to make pyproject.toml look less insane and I don't expect to do this again.

> - parser function is moved from command.py, or command.py itself is renamed
> - parser function is renamed

These are possible, of course, but I doubt they are likely to happen. Even if
it does, since it's an auxiliary feature, I don't really worry too much about
introducing this regression.

> Does that seem like a reasonable argument, or do you prefer the
> standalone script approach?

I still prefer to go with the CLI solution. I'm going to commit the script to
misc (giving you proper attribution) and we'll try it out.

-K