From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: tools@kernel.org
Subject: Re: b4: use new trailers in 'b4 send --resend'
Date: Mon, 29 Apr 2024 12:17:12 +0200 [thread overview]
Message-ID: <20240429121712.1b54f5fc@booty> (raw)
In-Reply-To: <20240426-tremendous-rhino-of-assurance-ad5e99@lemur>
Hello Konstantin,
On Fri, 26 Apr 2024 14:04:49 -0400
Konstantin Ryabitsev <konstantin@linuxfoundation.org> wrote:
> On Fri, Apr 26, 2024 at 06:44:25PM GMT, Luca Ceresoli wrote:
> > > It's not really necessary to resend a series just for trailer
> > > changes anyway. The maintainer will most likely use b4 to retrieve
> > > it anyway, and that will pull in any new trailers.
> >
> > I cannot recall exactly when it did happen and provide a link right now,
> > but I clearly remember having been asked by some maintainer to do
> > exactly this, instead of pinging.
> >
> > The rationale is that sending a new version just to add review tags was
> > considered bad because one can expect the patches or commit description
> > to have changed somewhat, which it hasn't.
>
> Yes, to be clear -- I wasn't suggesting that you send a new revision
> just to add trailers either. We're both aligned here.
>
> > OTOH resending without new trailers can lead to applying a patch
> > without those tags (not recognizing reviewers time), or even worse to
> > discard a patch because it does not show the needed tags.
>
> I expect this is one of those "every subsystem does things slightly
> differently" situation. If the maintainer uses b4, this entire step is
> unnecessary, because any missing trailers will be applied anyway when
> they run "b4 am".
Ah, interesting feature. I had no idea about it as I'm using b4 for
sending patches only. Thanks for the clarification!
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-04-29 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-26 12:01 b4: use new trailers in 'b4 send --resend' Luca Ceresoli
2024-04-26 15:11 ` Konstantin Ryabitsev
2024-04-26 16:44 ` Luca Ceresoli
2024-04-26 18:04 ` Konstantin Ryabitsev
2024-04-29 10:17 ` Luca Ceresoli [this message]
2024-04-29 14:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240429121712.1b54f5fc@booty \
--to=luca.ceresoli@bootlin.com \
--cc=konstantin@linuxfoundation.org \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox