Re: b4 adds changelog before the cover letter

[Maxime Ripard <mripard@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1484 bytes --]

On Tue, May 21, 2024 at 01:44:04PM GMT, Konstantin Ryabitsev wrote:
> On Tue, May 21, 2024 at 12:38:57PM GMT, Maxime Ripard wrote:
> > I've just noticed that after sending a series, b4 add the changes 
> > before
> > the rest of the cover letter.
> > 
> > For example, I've just sent this series:
> > https://lore.kernel.org/r/20240521-kms-hdmi-connector-state-v14-0-51950db4fedb@kernel.org
> > 
> > Prior to sending the series, this was the commit containing the cover letter:
> > https://github.com/mripard/linux/commit/062e28a73fd2
> > 
> > Right after b4 send was done, this is now the commit:
> > https://github.com/mripard/linux/commit/0d20a4123b4435c41177e2cc9122f7d335f7399e
> > 
> > It's not clear to me what is going on, but other series on other
> > machines with the same system and b4 versions don't show the same
> > behaviour, so it's probably an unlikely bug, or related to the local
> > configuration.
> 
> This is because normally there would be a --- between the trailers and 
> the changelog, e.g.:
> 
>   Cc: linux-rockchip@lists.infradead.org
>   Cc: linux-sunxi@lists.linux.dev
>   Signed-off-by: Maxime Ripard <mripard@kernel.org>
>   ---
> 
>   Changes in v14:
> 
> That "---" is crucial for us to properly find the start of the changelog 
> section. This logic can certainly be improved to be less fragile, but 
> for the moment putting back the --- is the only way to fix this for you.

Oh, of course. Thanks :)

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 273 bytes --]