Single patch ranges no longer understood

Single patch ranges no longer understood

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 663 bytes --]

Hi,

If I run

  $ b4 am -S -t -g -3 -o /tmp/x -P 1 4ce8c4f16f1cf3aa4e5f36c0694dd3c5ccf3cd1c.1716870419.git.alina_yu@richtek.com

I get:

  Analyzing 6 messages in the thread
  Unknown range value specified: 1
  Checking attestation on all messages, may take a moment...
  ---
    ---
    ✓ Signed: DKIM/richtek.com
  ---
  Total patches: 0 (cherrypicked: 1)

which is not good both since the failure to find any patches isn't
clearly reported and since I'd expect to get patch 1 fetched.  If I
instead specify the pick as "1-1" it fetches patch 1 as expected.  I'm
fairly sure just specifying a patch number used to work.

Thanks,
Mark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Single patch ranges no longer understood

[Konstantin Ryabitsev]

On Tue, May 28, 2024 at 01:23:14PM GMT, Mark Brown wrote:
> Hi,
> 
> If I run
> 
>   $ b4 am -S -t -g -3 -o /tmp/x -P 1 4ce8c4f16f1cf3aa4e5f36c0694dd3c5ccf3cd1c.1716870419.git.alina_yu@richtek.com
> 
> I get:
> 
>   Analyzing 6 messages in the thread
>   Unknown range value specified: 1
>   Checking attestation on all messages, may take a moment...
>   ---
>     ---
>     ✓ Signed: DKIM/richtek.com
>   ---
>   Total patches: 0 (cherrypicked: 1)
> 
> which is not good both since the failure to find any patches isn't
> clearly reported and since I'd expect to get patch 1 fetched.  If I
> instead specify the pick as "1-1" it fetches patch 1 as expected.  I'm
> fairly sure just specifying a patch number used to work.

Thanks for the report. It's probably the side-effect of this:
https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=2c6f29168557b64650ad53494a7be282efcfd74b

I'll either roll back or attempt to fix.

bugbot assign to me

-K

Re: Single patch ranges no longer understood

[Kernel.org Bugbot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=218910

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

Re: Single patch ranges no longer understood

[Kernel.org Bugbot]

Konstantin Ryabitsev writes in commit 2ee9fb76c69ddf47c80038df9fe3f0cb4df4bd67:

Fix parsing non-negative single numbers with parse_int_range()

Fix a regression when parsing single non-negative numbers. Add a test
for this and other conditions, so we catch this in the future.

Fixes: 18e6921e8b ("Allow negative number in parse_int_range()")
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218910
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=2ee9fb76c69d)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)