Thread breaking behaviour for non-patch messages

Thread breaking behaviour for non-patch messages

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Hi Konstantin,

Since updating to current git b4 with the new thread breaking support
for fetching patches sent in reply to serieses b4 mbox has started
misbehaving - if I try to fetch a thread by specifiying a message ID
somewhere in the middle it breaks the thread:

  $ b4 mbox CA+EHjTz_u2M-wsNnD_f=_R+dJoYwL9gUrBz=YwdqGZbtTT-aaA@mail.gmail.com
  Breaking thread to remove parents of CA+EHjTz_u2M-wsNnD_f=_R+dJoYwL9gUrBz=YwdqGZbtTT-aaA@mail.gmail.com
  1 messages in the thread
  Saved ./CA+EHjTz_u2M-wsNnD_f__R+dJoYwL9gUrBz_YwdqGZbtTT-aaA@mail.gmail.com.mbx

which is surprising and not so desirable in the non am case.

Thanks,
Mark


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Thread breaking behaviour for non-patch messages

[Konstantin Ryabitsev]

On Mon, Jun 03, 2024 at 02:00:31PM GMT, Mark Brown wrote:
> Since updating to current git b4 with the new thread breaking support
> for fetching patches sent in reply to serieses b4 mbox has started
> misbehaving - if I try to fetch a thread by specifiying a message ID
> somewhere in the middle it breaks the thread:
> 
>   $ b4 mbox CA+EHjTz_u2M-wsNnD_f=_R+dJoYwL9gUrBz=YwdqGZbtTT-aaA@mail.gmail.com
>   Breaking thread to remove parents of CA+EHjTz_u2M-wsNnD_f=_R+dJoYwL9gUrBz=YwdqGZbtTT-aaA@mail.gmail.com
>   1 messages in the thread
>   Saved ./CA+EHjTz_u2M-wsNnD_f__R+dJoYwL9gUrBz_YwdqGZbtTT-aaA@mail.gmail.com.mbx
> 
> which is surprising and not so desirable in the non am case.

bugbot assign to me

Re: Thread breaking behaviour for non-patch messages

[Kernel.org Bugbot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=218933

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)

Re: Thread breaking behaviour for non-patch messages

[Kernel.org Bugbot]

Konstantin Ryabitsev writes in commit d47074144878a7e027e20c90d00159d2e35bd9d1:

Improve auto-noparenting logic to require a diff/diffstat

This is a partial fix for the reported problem -- we still need to be
able to retrieve the full thread in mbox mode, even if we're pointing at
a standalone patch in the middle of a thread. The auto-noparenting
should be specific to the am mode. That said, with this change, this
will likely behave as expected in the vast majority of situations.

Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218933
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=d47074144878)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (peebz 0.1)