b4 send: pre-flight checks: add reminder for "b4 trailers"

b4 send: pre-flight checks: add reminder for "b4 trailers"

[Matthieu Baerts]

Hi Konstantin,

Thank you again for this great tool!

It is great to have 'b4 send' warning us when we forgot to edit the
cover-letter, add people in to/cc, and do some various checks.

Do you think 'b4 send' could also warn us when we need to execute 'b4
trailers -u' when we send newer versions?

When I need to send new versions, I don't often have to do fetch
code-review trailers, but then when I should, I tend to forget :)

Cheers,
Matt

Re: b4 send: pre-flight checks: add reminder for "b4 trailers"

[Konstantin Ryabitsev]

On Fri, Sep 06, 2024 at 11:50:32AM GMT, Matthieu Baerts wrote:
> It is great to have 'b4 send' warning us when we forgot to edit the
> cover-letter, add people in to/cc, and do some various checks.
> 
> Do you think 'b4 send' could also warn us when we need to execute 'b4
> trailers -u' when we send newer versions?

I've thought about it, but I'm not sure it would be as useful. As opposed to
all other pre-flight checks, this one is not something you need to do after
your tree changes. It's the kind of thing you probably want to run right
before sending the next revision, so we need to cache the check based on time,
not on the state of the tree.

> When I need to send new versions, I don't often have to do fetch
> code-review trailers, but then when I should, I tend to forget :)

Even if the submitter forgets to do it, the maintainer pulling in the series
will get these trailers anyway (assuming they use b4, of course).

So... I'll think about it. :)

bugbot assign to me

-K

Re: b4 send: pre-flight checks: add reminder for "b4 trailers"

[Kernel.org Bugbot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=219245

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)