Missing `Signed-off-by` line in patch email

Missing `Signed-off-by` line in patch email

[Cryolitia PukNgae]

To whom it may concern,

I am a newbie recently using b4 to contribute to kernel.

Several months ago, I sent a patch with the wrong format.^1

I forgot to sign off my commit, but when I run `b4 prep --check` , it
didn't warn me about it.

I used `b4 send` to send this patch to maillist, b4 appended the
"Signed-off-by" line below the wrong divider.

My origin branch is on Github.^2

1. https://lore.kernel.org/lkml/20240726-typo-v1-1-3ca3f07f93e9@gmail.com/
2. https://github.com/Cryolitia-Forks/linux/tree/b4/typo

Best wishes,
Cryolitia

Re: Missing `Signed-off-by` line in patch email

[Konstantin Ryabitsev]

On Sat, Oct 19, 2024 at 01:43:01PM +0800, Cryolitia PukNgae wrote:
> I am a newbie recently using b4 to contribute to kernel.
> 
> Several months ago, I sent a patch with the wrong format.^1
> 
> I forgot to sign off my commit, but when I run `b4 prep --check` , it
> didn't warn me about it.

Interesting. If I run checkpatch without --mailback, it reports the error:

    $ git --no-pager show --format=email --full-index --binary --patch-with-stat \
        --encoding=utf-8 97fee61300b9c3eb200f9d1f180966acaa288f82 \
        | ./scripts/checkpatch.pl --terse --no-summary --strict --showfile
    Documentation/hwmon/oxp-sensors.rst:58: ERROR: Missing Signed-off-by: line(s)

However, if I add --mailback, the error is gone. This doesn't make sense to
me, but I'll raise this with checkpatch maintainers.

> I used `b4 send` to send this patch to maillist, b4 appended the
> "Signed-off-by" line below the wrong divider.
> 
> My origin branch is on Github.^2
> 
> 1. https://lore.kernel.org/lkml/20240726-typo-v1-1-3ca3f07f93e9@gmail.com/
> 2. https://github.com/Cryolitia-Forks/linux/tree/b4/typo

Thank you for the report. I'll see if we can handle this situation more
properly. For my record, this is what is happening:

1. There is only one commit, and it is missing the S-o-b.
2. The cover letter has the standard S-o-b.
3. When we "mix-in" the cover letter under the "---" divider, the S-o-b
   trailer from the cover letter is added under the divider.

My preferred solution would be: when mixing in cover letter content, move all
trailers from the cover letter into the first patch.

-K

bugspray tag me

Re: Missing `Signed-off-by` line in patch email

[Bugspray Bot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=219412

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: Missing `Signed-off-by` line in patch email

[Cryolitia PukNgae]

在 2024/10/22 04:14, Konstantin Ryabitsev 写道:
> On Sat, Oct 19, 2024 at 01:43:01PM +0800, Cryolitia PukNgae wrote:
>> I am a newbie recently using b4 to contribute to kernel.
>>
>> Several months ago, I sent a patch with the wrong format.^1
>>
>> I forgot to sign off my commit, but when I run `b4 prep --check` , it
>> didn't warn me about it.
> 
> Interesting. If I run checkpatch without --mailback, it reports the error:
> 
>      $ git --no-pager show --format=email --full-index --binary --patch-with-stat \
>          --encoding=utf-8 97fee61300b9c3eb200f9d1f180966acaa288f82 \
>          | ./scripts/checkpatch.pl --terse --no-summary --strict --showfile
>      Documentation/hwmon/oxp-sensors.rst:58: ERROR: Missing Signed-off-by: line(s)
> 
> However, if I add --mailback, the error is gone. This doesn't make sense to
> me, but I'll raise this with checkpatch maintainers.

Thanks, plz cc me :)

>> I used `b4 send` to send this patch to maillist, b4 appended the
>> "Signed-off-by" line below the wrong divider.
>>
>> My origin branch is on Github.^2
>>
>> 1. https://lore.kernel.org/lkml/20240726-typo-v1-1-3ca3f07f93e9@gmail.com/
>> 2. https://github.com/Cryolitia-Forks/linux/tree/b4/typo
> 
> Thank you for the report. I'll see if we can handle this situation more
> properly. For my record, this is what is happening:
> 
> 1. There is only one commit, and it is missing the S-o-b.
> 2. The cover letter has the standard S-o-b.
> 3. When we "mix-in" the cover letter under the "---" divider, the S-o-b
>     trailer from the cover letter is added under the divider.
> 
> My preferred solution would be: when mixing in cover letter content, move all
> trailers from the cover letter into the first patch.

Sounds good to me.

Thanks,
Cryolitia