Bug? in b4 shazam when reading from local mailbox

Bug? in b4 shazam when reading from local mailbox

[Ricardo Ribalda]

Hi Konstantin

I think our CI bot has found another issue.

I get this error when I try to do shazam from a mbox that I have
previously downloaded.
It does not happen for every series.

ribalda@denia:~/work/linux$ ../b4/b4.sh mbox
20241105-uvc-crashrmmod-v3-1-c0959c8906d3@chromium.org -n test.mbx ;
../b4/b4.sh shazam -m test.mbx
Grabbing thread from
lore.kernel.org/all/20241105-uvc-crashrmmod-v3-1-c0959c8906d3%40chromium.org/t.mbox.gz
1 messages in the thread
Saved ./test.mbx
Checking for newer revisions
Grabbing search results from lore.kernel.org
Traceback (most recent call last):
  File "/usr/local/google/home/ribalda/work/b4/b4/command.py", line
373, in <module>
    cmd()
  File "/usr/local/google/home/ribalda/work/b4/b4/command.py", line 356, in cmd
    cmdargs.func(cmdargs)
  File "/usr/local/google/home/ribalda/work/b4/b4/command.py", line
96, in cmd_shazam
    b4.mbox.main(cmdargs)
  File "/usr/local/google/home/ribalda/work/b4/b4/mbox.py", line 670, in main
    msgs = get_extra_series(msgs, direction=1, nocache=cmdargs.nocache)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/google/home/ribalda/work/b4/b4/mbox.py", line 632,
in get_extra_series
    msgs.append(q_msg)
    ^^^^^^^^^^^
AttributeError: 'mbox' object has no attribute 'append'

If I add the command --offline-mode to shazam, it works as expected

Regards!

-- 
Ricardo Ribalda
Software Engineer
ribalda@google.com

Re: Bug? in b4 shazam when reading from local mailbox

[Konstantin Ryabitsev]

On Tue, Nov 05, 2024 at 11:14:34PM +0100, Ricardo Ribalda wrote:
> Hi Konstantin
> 
> I think our CI bot has found another issue.

It's not really surprising, considering you're putting b4 through more abuse
than anyone else. It's good, though -- we're finding all kinds of bugs that
were lurking beneath the surface.

bugspray tag me

Re: Bug? in b4 shazam when reading from local mailbox

[Bugspray Bot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=219471

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)