tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: tools@kernel.org
Subject: [PATCH 2/2] Allow --guess-branch argument with shazam -H/-M options
Date: Wed,  8 Jan 2025 17:12:03 -0600	[thread overview]
Message-ID: <20250108231203.1209721-2-robh@kernel.org> (raw)
In-Reply-To: <20250108231203.1209721-1-robh@kernel.org>

For the b4 shazam cases which create a FETCH_HEAD, it's useful to be able
to specify the branch to use for guessing the base commit rather than just
using HEAD.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
 src/b4/command.py | 2 ++
 src/b4/mbox.py    | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/b4/command.py b/src/b4/command.py
index e31ee052c9cd..99854e9932c0 100644
--- a/src/b4/command.py
+++ b/src/b4/command.py
@@ -206,6 +206,8 @@ def setup_parser() -> argparse.ArgumentParser:
                       help='Attempt to treat series as a pull request and fetch it into FETCH_HEAD')
     sh_g.add_argument('-M', '--merge', dest='merge', action='store_true', default=False,
                       help='Attempt to merge series as if it were a pull request (execs git-merge)')
+    sp_sh.add_argument('-b', '--guess-branch', dest='guessbranch', nargs=1, action='extend', type=str, default=None,
+                       help='(use with -H or -M) When guessing base, restrict to this branch (use with -g)')
     sp_sh.add_argument('--guess-lookback', dest='guessdays', type=int, default=21,
                        help=('(use with -H or -M) When guessing base, go back this many days from the patch date '
                              '(default: 3 weeks)'))
diff --git a/src/b4/mbox.py b/src/b4/mbox.py
index 7061d1493be3..768a896904ad 100644
--- a/src/b4/mbox.py
+++ b/src/b4/mbox.py
@@ -783,13 +783,13 @@ def main(cmdargs: argparse.Namespace) -> None:
         cmdargs.threeway = False
         cmdargs.nopartialreroll = False
         cmdargs.outdir = '-'
-        cmdargs.guessbranch = None
         if cmdargs.merge:
             cmdargs.makefetchhead = True
         if cmdargs.makefetchhead:
             cmdargs.guessbase = True
         else:
             cmdargs.guessbase = False
+            cmdargs.guessbranch = None
     else:
         cmdargs.mergebase = False
 
-- 
2.45.2


      reply	other threads:[~2025-01-08 23:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-08 23:12 [PATCH 1/2] Limit --guess-branch argument to 1 branch Rob Herring (Arm)
2025-01-08 23:12 ` Rob Herring (Arm) [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250108231203.1209721-2-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).