* [PATCH 1/2] Limit --guess-branch argument to 1 branch
@ 2025-01-08 23:12 Rob Herring (Arm)
2025-01-08 23:12 ` [PATCH 2/2] Allow --guess-branch argument with shazam -H/-M options Rob Herring (Arm)
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2025-01-08 23:12 UTC (permalink / raw)
To: tools
More than 1 branch argument doesn't work correctly, so restrict it to 1
arg. The help text already implies it is a single branch.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
src/b4/command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/b4/command.py b/src/b4/command.py
index 5d90b4f52b4f..e31ee052c9cd 100644
--- a/src/b4/command.py
+++ b/src/b4/command.py
@@ -184,7 +184,7 @@ def setup_parser() -> argparse.ArgumentParser:
help='Save patches in a quilt-ready folder')
sp_am.add_argument('-g', '--guess-base', dest='guessbase', action='store_true', default=False,
help='Try to guess the base of the series (if not specified)')
- sp_am.add_argument('-b', '--guess-branch', dest='guessbranch', nargs='+', action='extend', type=str, default=None,
+ sp_am.add_argument('-b', '--guess-branch', dest='guessbranch', nargs=1, action='extend', type=str, default=None,
help='When guessing base, restrict to this branch (use with -g)')
sp_am.add_argument('--guess-lookback', dest='guessdays', type=int, default=21,
help='When guessing base, go back this many days from the patch date (default: 2 weeks)')
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH 2/2] Allow --guess-branch argument with shazam -H/-M options
2025-01-08 23:12 [PATCH 1/2] Limit --guess-branch argument to 1 branch Rob Herring (Arm)
@ 2025-01-08 23:12 ` Rob Herring (Arm)
0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring (Arm) @ 2025-01-08 23:12 UTC (permalink / raw)
To: tools
For the b4 shazam cases which create a FETCH_HEAD, it's useful to be able
to specify the branch to use for guessing the base commit rather than just
using HEAD.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
src/b4/command.py | 2 ++
src/b4/mbox.py | 2 +-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/b4/command.py b/src/b4/command.py
index e31ee052c9cd..99854e9932c0 100644
--- a/src/b4/command.py
+++ b/src/b4/command.py
@@ -206,6 +206,8 @@ def setup_parser() -> argparse.ArgumentParser:
help='Attempt to treat series as a pull request and fetch it into FETCH_HEAD')
sh_g.add_argument('-M', '--merge', dest='merge', action='store_true', default=False,
help='Attempt to merge series as if it were a pull request (execs git-merge)')
+ sp_sh.add_argument('-b', '--guess-branch', dest='guessbranch', nargs=1, action='extend', type=str, default=None,
+ help='(use with -H or -M) When guessing base, restrict to this branch (use with -g)')
sp_sh.add_argument('--guess-lookback', dest='guessdays', type=int, default=21,
help=('(use with -H or -M) When guessing base, go back this many days from the patch date '
'(default: 3 weeks)'))
diff --git a/src/b4/mbox.py b/src/b4/mbox.py
index 7061d1493be3..768a896904ad 100644
--- a/src/b4/mbox.py
+++ b/src/b4/mbox.py
@@ -783,13 +783,13 @@ def main(cmdargs: argparse.Namespace) -> None:
cmdargs.threeway = False
cmdargs.nopartialreroll = False
cmdargs.outdir = '-'
- cmdargs.guessbranch = None
if cmdargs.merge:
cmdargs.makefetchhead = True
if cmdargs.makefetchhead:
cmdargs.guessbase = True
else:
cmdargs.guessbase = False
+ cmdargs.guessbranch = None
else:
cmdargs.mergebase = False
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-08 23:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-08 23:12 [PATCH 1/2] Limit --guess-branch argument to 1 branch Rob Herring (Arm)
2025-01-08 23:12 ` [PATCH 2/2] Allow --guess-branch argument with shazam -H/-M options Rob Herring (Arm)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).