Problem with "b4 pr" ?

Problem with "b4 pr" ?

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

Hey,

With:
$ b4 --version
0.14.2

When trying to apply this PR to U-Boot:
https://lore.kernel.org/all/7caf7a0a-c2ed-420c-afc7-620ab11461b5@linaro.org/

I get this error:
$ b4 pr 7caf7a0a-c2ed-420c-afc7-620ab11461b5@linaro.org
Looking at: Please pull u-boot-net-20250212
ERROR: Could not find pull request info in 7caf7a0a-c2ed-420c-afc7-620ab11461b5@linaro.org

I'm unsure if this is a parsing error (as I've had "b4 pr" dislike
git@host:path URIs, but I've told custodians how to setup a url and
pushurl to avoid that) due to the trailing / on the repository, or an
oddly phrased error message because the commit in question isn't in
u-boot-net-20250212 but rather then "for-tom" branch.

Just passing this along, thanks again for the very useful tool!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: Problem with "b4 pr" ?

[Konstantin Ryabitsev]

On Wed, Feb 12, 2025 at 10:50:45AM -0600, Tom Rini wrote:
> Hey,
> 
> With:
> $ b4 --version
> 0.14.2
> 
> When trying to apply this PR to U-Boot:
> https://lore.kernel.org/all/7caf7a0a-c2ed-420c-afc7-620ab11461b5@linaro.org/
> 
> I get this error:
> $ b4 pr 7caf7a0a-c2ed-420c-afc7-620ab11461b5@linaro.org
> Looking at: Please pull u-boot-net-20250212
> ERROR: Could not find pull request info in 7caf7a0a-c2ed-420c-afc7-620ab11461b5@linaro.org
> 
> I'm unsure if this is a parsing error (as I've had "b4 pr" dislike
> git@host:path URIs, but I've told custodians how to setup a url and
> pushurl to avoid that) due to the trailing / on the repository, or an
> oddly phrased error message because the commit in question isn't in
> u-boot-net-20250212 but rather then "for-tom" branch.

Right, we need a better error message here, but the fault is with the data in
the pull request. It's telling you to:

    are available in the Git repository at:

      https://source.denx.de/u-boot/custodians/u-boot-net.git/ u-boot-net-20250212

But that ref/tag doesn't exist in that repository.

    $ git ls-remote https://source.denx.de/u-boot/custodians/u-boot-net.git | grep 2025
    (returns nothing)

So, we'll still error out, but the message should be:

    ERROR: Could not find u-boot-net-20250212 in https://source.denx.de/u-boot/custodians/u-boot-net.git

-K

bugspray tag me

Re: Problem with "b4 pr" ?

[Bugspray Bot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=219778

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)