b4 am getting extra patches and missing patches

b4 am getting extra patches and missing patches

[Andreas Larsson]

Hi,

First of all, thank you for the wonderful tool that b4 is!


I am trying this with b4 version 0.14.2 (as well as using current
master), getting this strange result:

----%<----
$ b4 am https://lore.kernel.org/all/20250218-jag-mv_ctltables-v1-0-cd3698ab8d29@kernel.org/T/#m6e83d4c31cffc76f16d830bbb79c9e3efd1e4d89 
Analyzing 17 messages in the thread
WARNING: duplicate messages found at index 1
   Subject 1: perf/core: Move perf_event sysctls into kernel/events
   Subject 2: panic: Move panic ctl tables into panic.c
  2 is not a reply... assume additional patch
WARNING: duplicate messages found at index 1
   Subject 1: x86: Move sysctls into arch/x86
   Subject 2: perf/core: Move perf_event sysctls into kernel/events
  2 is not a reply... assume additional patch
Analyzing 0 code-review messages
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH] x86: Move sysctls into arch/x86
    ✓ Signed: DKIM/linutronix.de
  ✓ [PATCH] perf/core: Move perf_event sysctls into kernel/events
    ✓ Signed: DKIM/linutronix.de
  ✗ [PATCH 3/8] ftrace: Move trace sysctls into trace.c
    ✗ BADSIG: openpgp/joel.granados@kernel.org
    ✓ Signed: DKIM/kernel.org
    + Acked-by: Steven Rostedt (Google) <rostedt@goodmis.org>
  ✗ [PATCH 4/8] stack_tracer: move sysctl registration to kernel/trace/trace.c
    ✗ BADSIG: openpgp/joel.granados@kernel.org
    ✓ Signed: DKIM/kernel.org
  ✗ [PATCH 5/8] events: Move perf_event sysctls into kernel/events
    ✗ BADSIG: openpgp/joel.granados@kernel.org
    ✓ Signed: DKIM/kernel.org
    + Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> (✓ DKIM/infradead.org)
  ✗ [PATCH 6/8] sparc: mv sparc sysctls into their own file under arch/sparc/kernel
    ✗ BADSIG: openpgp/joel.granados@kernel.org
    ✓ Signed: DKIM/kernel.org
  ✗ [PATCH 7/8] s390: mv s390 sysctls into their own file under arch/s390 dir
    ✗ BADSIG: openpgp/joel.granados@kernel.org
    ✓ Signed: DKIM/kernel.org
  ✗ [PATCH 8/8] x86: Move sysctls into arch/x86
    ✗ BADSIG: openpgp/joel.granados@kernel.org
    ✓ Signed: DKIM/kernel.org
  ERROR: missing [9/8]!
  ERROR: missing [10/8]!
---
Total patches: 8
---
WARNING: Thread incomplete!
Cover: ./20250218_joel_granados_sysctl_move_sysctls_from_kern_table_into_their_respective_subsystems.cover
 Link: https://lore.kernel.org/r/20250218-jag-mv_ctltables-v1-0-cd3698ab8d29@kernel.org
 Base: using specified base-commit 0ad2507d5d93f39619fc42372c347d6006b64319
       git checkout -b 20250218_joel_granados_kernel_org 0ad2507d5d93f39619fc42372c347d6006b64319
       git am ./20250218_joel_granados_sysctl_move_sysctls_from_kern_table_into_their_respective_subsystems.mbx
----%<----


The two first patches are not actually from the email thread, but
replaces the first two patches that are in the email thread.


Using --single-message on the first patch of the thread does not work
either:

----%<----
$ b4 am --single-message https://lore.kernel.org/all/20250218-jag-mv_ctltables-v1-0-cd3698ab8d29@kernel.org/T/#m76f58f40fe66b018d8f86485b46e07bdf1bec99e
Single-message mode, ignoring any follow-ups
Analyzing 1 messages in the thread
No patches found.
----%<----


I am not sure what to make of this.

Cheers,
Andreas

Re: b4 am getting extra patches and missing patches

[Konstantin Ryabitsev]

On Tue, Mar 04, 2025 at 04:42:33PM +0100, Andreas Larsson wrote:
> $ b4 am https://lore.kernel.org/all/20250218-jag-mv_ctltables-v1-0-cd3698ab8d29@kernel.org/T/#m6e83d4c31cffc76f16d830bbb79c9e3efd1e4d89 

Looking at that thread, the messages that mess everything up are from the
tip-bot, because they technically contain patches that are unversioned. When
b4 sees them in the thread, it's not sure what to do with them. Unfortunately,
it also breaks in an unexpected way, because it adds them as 1/8 and 2/8 and
also increments the total count to 10 patches (which is why it complains about
9/8 and 10/8 missing).

I'll try to untangle this mess, but it does work better if tip-bot sends those
messages with "Re: " in the subject.

bugspray tag me

-K

Re: b4 am getting extra patches and missing patches

[Bugspray Bot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=219843

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)