Re: b4 thank-you letter shows incorrect repo URL

Re: b4 thank-you letter shows incorrect repo URL

[Konstantin Ryabitsev]

On Thu, May 01, 2025 at 10:06:22PM +0800, Chen-Yu Tsai wrote:
> (dropped most people and lists from CC; added Konstantin and kernel.org users)

Note, it should go to tools@kernel.org, not users@kernel.org.

> > > Applied to clk-fixes-for-6.15 in git@github.com:linux-sunxi/linux-sunxi.git, thanks!
> >
> > thanks for that, but the URL here is not correct, is it? Should be the
> > kernel.org repo instead? Saw this already in other "applied" emails.
> 
> That's weird. It is correctly pushed to the kernel.org repo [1].
> Maybe it's because the git-config remote entry for korg repo's  is called
> "sunxi-korg", and the linux-sunxi one on GitHub is called "sunxi", and
> somehow b4 is getting confused?
> 
> Konstantin, have you heard of such reports? FYI my b4 is version 0.14.2.

This is coming from your custom template, not from b4 itself. By default, b4
just says "Applied to ${branch}".

Regards,
-K

Re: b4 thank-you letter shows incorrect repo URL

[Chen-Yu Tsai]

On Thu, May 1, 2025 at 10:26 PM Konstantin Ryabitsev
<konstantin@linuxfoundation.org> wrote:
>
> On Thu, May 01, 2025 at 10:06:22PM +0800, Chen-Yu Tsai wrote:
> > (dropped most people and lists from CC; added Konstantin and kernel.org users)
>
> Note, it should go to tools@kernel.org, not users@kernel.org.

Ack. Dropping users@kernel.org.

> > > > Applied to clk-fixes-for-6.15 in git@github.com:linux-sunxi/linux-sunxi.git, thanks!
> > >
> > > thanks for that, but the URL here is not correct, is it? Should be the
> > > kernel.org repo instead? Saw this already in other "applied" emails.
> >
> > That's weird. It is correctly pushed to the kernel.org repo [1].
> > Maybe it's because the git-config remote entry for korg repo's  is called
> > "sunxi-korg", and the linux-sunxi one on GitHub is called "sunxi", and
> > somehow b4 is getting confused?
> >
> > Konstantin, have you heard of such reports? FYI my b4 is version 0.14.2.
>
> This is coming from your custom template, not from b4 itself. By default, b4
> just says "Applied to ${branch}".

My template is: "Applied to ${branch} in ${treename}, thanks!"

My .git/config is as follows:

[remote "sunxi"]
        url = git@github.com:linux-sunxi/linux-sunxi.git
        tagopt = --no-tags
        fetch = +refs/heads/*:refs/remotes/sunxi-github/*
[remote "sunxi-korg"]
        url = https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git
        pushURL = git@gitolite.kernel.org:pub/scm/linux/kernel/git/sunxi/linux
        fetch = +refs/heads/*:refs/remotes/sunxi-korg/*
        tagopt = --no-tags
        b4-commit-url-mask = https://git.kernel.org/sunxi/linux/c/%.12s

Also, the branch I applied it to is named "sunxi/clk-fixes-for-6.15",
both locally and in the kernel.org repo, not "clk-fixes-for-6.15" as
shown in the original thank-you email.

I think there is a parsing error somewhere. Maybe b4 isn't dealing with
nested branch names correctly and somehow thinks the "sunxi/" part is
actually the remote name.

If I rename the "sunxi" remote to "sunxi-github", `b4 ty` now generates:

    Applied to sunxi/clk-fixes-for-6.15 in local tree, thanks!

Again this seems to point to accidentally treating part of the branch name
as the remote name.


ChenYu

Re: b4 thank-you letter shows incorrect repo URL

[Chen-Yu Tsai]

On Thu, May 1, 2025 at 11:45 PM Chen-Yu Tsai <wens@csie.org> wrote:
>
> On Thu, May 1, 2025 at 10:26 PM Konstantin Ryabitsev
> <konstantin@linuxfoundation.org> wrote:
> >
> > On Thu, May 01, 2025 at 10:06:22PM +0800, Chen-Yu Tsai wrote:
> > > (dropped most people and lists from CC; added Konstantin and kernel.org users)
> >
> > Note, it should go to tools@kernel.org, not users@kernel.org.
>
> Ack. Dropping users@kernel.org.
>
> > > > > Applied to clk-fixes-for-6.15 in git@github.com:linux-sunxi/linux-sunxi.git, thanks!
> > > >
> > > > thanks for that, but the URL here is not correct, is it? Should be the
> > > > kernel.org repo instead? Saw this already in other "applied" emails.
> > >
> > > That's weird. It is correctly pushed to the kernel.org repo [1].
> > > Maybe it's because the git-config remote entry for korg repo's  is called
> > > "sunxi-korg", and the linux-sunxi one on GitHub is called "sunxi", and
> > > somehow b4 is getting confused?
> > >
> > > Konstantin, have you heard of such reports? FYI my b4 is version 0.14.2.
> >
> > This is coming from your custom template, not from b4 itself. By default, b4
> > just says "Applied to ${branch}".
>
> My template is: "Applied to ${branch} in ${treename}, thanks!"
>
> My .git/config is as follows:
>
> [remote "sunxi"]
>         url = git@github.com:linux-sunxi/linux-sunxi.git
>         tagopt = --no-tags
>         fetch = +refs/heads/*:refs/remotes/sunxi-github/*
> [remote "sunxi-korg"]
>         url = https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git
>         pushURL = git@gitolite.kernel.org:pub/scm/linux/kernel/git/sunxi/linux
>         fetch = +refs/heads/*:refs/remotes/sunxi-korg/*
>         tagopt = --no-tags
>         b4-commit-url-mask = https://git.kernel.org/sunxi/linux/c/%.12s
>
> Also, the branch I applied it to is named "sunxi/clk-fixes-for-6.15",
> both locally and in the kernel.org repo, not "clk-fixes-for-6.15" as
> shown in the original thank-you email.
>
> I think there is a parsing error somewhere. Maybe b4 isn't dealing with
> nested branch names correctly and somehow thinks the "sunxi/" part is
> actually the remote name.
>
> If I rename the "sunxi" remote to "sunxi-github", `b4 ty` now generates:
>
>     Applied to sunxi/clk-fixes-for-6.15 in local tree, thanks!
>
> Again this seems to point to accidentally treating part of the branch name
> as the remote name.

Also, I found a thank-you letter that is correct that is from Jan. 2025:

    https://lore.kernel.org/linux-sunxi/173617837421.3282465.589306007023383641.b4-ty@csie.org/

The next one that I found was incorrect. This one is from Feb. 2025:

    https://lore.kernel.org/linux-sunxi/173909140135.1184685.5784910677727356231.b4-ty@csie.org/

Though it could be I upgraded something on my workstation some time
in between.


ChenYu

Re: b4 thank-you letter shows incorrect repo URL

[Konstantin Ryabitsev]

On Thu, May 01, 2025 at 11:49:38PM +0800, Chen-Yu Tsai wrote:
> > > This is coming from your custom template, not from b4 itself. By default, b4
> > > just says "Applied to ${branch}".
> >
> > My template is: "Applied to ${branch} in ${treename}, thanks!"
> >
> > My .git/config is as follows:
> >
> > [remote "sunxi"]
> >         url = git@github.com:linux-sunxi/linux-sunxi.git
> >         tagopt = --no-tags
> >         fetch = +refs/heads/*:refs/remotes/sunxi-github/*
> > [remote "sunxi-korg"]
> >         url = https://git.kernel.org/pub/scm/linux/kernel/git/sunxi/linux.git
> >         pushURL = git@gitolite.kernel.org:pub/scm/linux/kernel/git/sunxi/linux
> >         fetch = +refs/heads/*:refs/remotes/sunxi-korg/*
> >         tagopt = --no-tags
> >         b4-commit-url-mask = https://git.kernel.org/sunxi/linux/c/%.12s
> >
> > Also, the branch I applied it to is named "sunxi/clk-fixes-for-6.15",
> > both locally and in the kernel.org repo, not "clk-fixes-for-6.15" as
> > shown in the original thank-you email.
> >
> > I think there is a parsing error somewhere. Maybe b4 isn't dealing with
> > nested branch names correctly and somehow thinks the "sunxi/" part is
> > actually the remote name.
> >
> > If I rename the "sunxi" remote to "sunxi-github", `b4 ty` now generates:
> >
> >     Applied to sunxi/clk-fixes-for-6.15 in local tree, thanks!
> >
> > Again this seems to point to accidentally treating part of the branch name
> > as the remote name.
> 
> Also, I found a thank-you letter that is correct that is from Jan. 2025:
> 
>     https://lore.kernel.org/linux-sunxi/173617837421.3282465.589306007023383641.b4-ty@csie.org/
> 
> The next one that I found was incorrect. This one is from Feb. 2025:
> 
>     https://lore.kernel.org/linux-sunxi/173909140135.1184685.5784910677727356231.b4-ty@csie.org/
> 
> Though it could be I upgraded something on my workstation some time
> in between.

Yes, I think there's a substring/partial match that causes this.

I'll take a look.

bugspray tag me

-K

Re: b4 thank-you letter shows incorrect repo URL

[Bugspray Bot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=220079

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)