tools.linux.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: tools@kernel.org
Subject: [b4] CRITICAL: prep-pre-flight-checks must be a list, got str
Date: Tue, 10 Jun 2025 12:46:24 -0700	[thread overview]
Message-ID: <20250610194624.GA1933519@ax162> (raw)

After commit 8cae108 ("Further mypy typing enhancements"), I am seeing
an error when running 'b4 send':

  $ b4 send
  Converted the branch to 1 messages
  CRITICAL: prep-pre-flight-checks must be a list, got str

The following diff appears to resolve it for me.

Cheers,
Nathan

diff --git a/src/b4/ez.py b/src/b4/ez.py
index 0b24d50..df248bf 100644
--- a/src/b4/ez.py
+++ b/src/b4/ez.py
@@ -2005,7 +2005,7 @@ def cmd_send(cmdargs: argparse.Namespace) -> None:
                         'needs-checking-deps': True,
                         'needs-auto-to-cc': True,
                         }
-            cfg_checks = config.get('prep-pre-flight-checks', 'enable-all')
+            cfg_checks = config.get('prep-pre-flight-checks', ['enable-all'])
             if not isinstance(cfg_checks, list):
                 logger.critical('CRITICAL: prep-pre-flight-checks must be a list, got %s', type(cfg_checks).__name__)
                 sys.exit(1)

             reply	other threads:[~2025-06-10 19:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-10 19:46 Nathan Chancellor [this message]
2025-06-11 15:07 ` [b4] CRITICAL: prep-pre-flight-checks must be a list, got str Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250610194624.GA1933519@ax162 \
    --to=nathan@kernel.org \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).