b4 am no longer prints file name

b4 am no longer prints file name

[Geert Uytterhoeven]

Hi Konstantin,

Thanks for your hard work on b4!
I wanted to try "b4 dig", so I upgraded.  After that, I noticed that
"b4 am <Message-Id>" no longer prints the actual filename where it saved
the mbox.  Hence I now have to do a manual look-up.  Apparently this
was dropped in commit 8c0f498752924b3d ("mbox: refactor how we treat
base_commit for am and shazam").

Perhaps this printing can be reinstated?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: b4 am no longer prints file name

[Konstantin Ryabitsev]

On Tue, Oct 14, 2025 at 06:03:58PM +0200, Geert Uytterhoeven wrote:
> Hi Konstantin,
> 
> Thanks for your hard work on b4!
> I wanted to try "b4 dig", so I upgraded.  After that, I noticed that
> "b4 am <Message-Id>" no longer prints the actual filename where it saved
> the mbox.  Hence I now have to do a manual look-up.  Apparently this
> was dropped in commit 8c0f498752924b3d ("mbox: refactor how we treat
> base_commit for am and shazam").
> 
> Perhaps this printing can be reinstated?

Yes this is a regression.

bugspray tag me

Re: b4 am no longer prints file name

[Bugspray Bot]

Hello:

This conversation is now tracked by Kernel.org Bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=220661

There is no need to do anything else, just keep talking.
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: b4 am no longer prints file name

[Bugspray Bot]

Konstantin Ryabitsev writes in commit bd7332f9094cb0c113c228f996991f2a42e641dd:

mbox: restore printing out of filename to git am

Looks like due to either inattention or bad auto-indenting, the part
that printed out the name to git am ended up buried inside the if
statement that is almost never called.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220661
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>

(via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=bd7332f9094c)
-- 
Deet-doot-dot, I am a bot.
Kernel.org Bugzilla (bugspray 0.1-dev)

Re: b4 am no longer prints file name

[Geert Uytterhoeven]

Hi Konstantin,

On Wed, 22 Oct 2025 at 21:55, Bugspray Bot <bugbot@kernel.org> wrote:
> Konstantin Ryabitsev writes in commit bd7332f9094cb0c113c228f996991f2a42e641dd:
>
> mbox: restore printing out of filename to git am
>
> Looks like due to either inattention or bad auto-indenting, the part
> that printed out the name to git am ended up buried inside the if
> statement that is almost never called.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=220661
> Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
>
> (via https://git.kernel.org/pub/scm/utils/b4/b4.git/commit/?id=bd7332f9094c)

Thank you, confirmed fixed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds