From: Lee Jones <lee@kernel.org>
To: "Vlastimil Babka (SUSE)" <vbabka@kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
tools@kernel.org, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: b4: ty: User-flow regression
Date: Tue, 21 Oct 2025 15:38:23 +0100 [thread overview]
Message-ID: <20251021143823.GH475031@google.com> (raw)
In-Reply-To: <08cb2b99-187e-46e5-8921-bbadd2a66636@kernel.org>
On Tue, 21 Oct 2025, Vlastimil Babka (SUSE) wrote:
> On 10/21/25 12:56, Lee Jones wrote:
> > On Sat, 11 Oct 2025, Greg KH wrote:
> >
> >> On Fri, Oct 10, 2025 at 10:37:22AM -0400, Konstantin Ryabitsev wrote:
> >> > On Fri, Oct 10, 2025 at 03:34:52PM +0100, Lee Jones wrote:
> >> > > > Next question is -- have you recently stopped adding Link: tags to your
> >> > > > commits? :)
> >> > >
> >> > > Oooo, yes! Yes, I have!
> >> > >
> >> > > Why would that make a difference?
> >> >
> >> > When patches have been altered by the maintainer, we can no longer match them
> >> > by git-patch-id.
> >>
> >> Which is the primary reason to keep the Link: stuff. Many maintainers
> >> manually change patches to fix up minor things all the time, and without
> >> the Link: it's a major pain to find (the LF sponsored a whole project
> >> just to do the backwards mapping for many years, but no one used it...)
> >>
> >> > In the past, when we found a Link: trailer, we could still
> >> > match their provenance by message-id, but if that is gone, we can no longer
> >> > fall back to that. I am working on making the "ty" mechanism being less
> >> > dependent on that -- hopefully the master branch should become more useful to
> >> > you again in the near future.
> >>
> >> message-id is important to track somehow, we need that link.
> >
> > It turns out that going back to manually thanking contributors is too
> > much of a regression for me ATM. For now at least, against Linus'
> > wishes (sadly), I'm putting Link:s back in.
>
> Linus later said he would tolerate them with the https://patch.msgid.link
> domain:
>
> https://lore.kernel.org/all/CAHk-=wj5MATvT-FR8qNpXuuBGiJdjY1kRfhtzuyBSpTKR+=Vtw@mail.gmail.com/
Okay, this works. Looks like b4 now supports that in `master` as:
52d380965c71 ("Set default linkmask to patch.msgid.link")
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2025-10-21 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-09 15:13 b4: ty: User-flow regression Lee Jones
2025-10-09 22:09 ` Konstantin Ryabitsev
2025-10-10 8:03 ` Lee Jones
2025-10-10 14:23 ` Konstantin Ryabitsev
2025-10-10 14:34 ` Lee Jones
2025-10-10 14:37 ` Konstantin Ryabitsev
2025-10-10 14:48 ` Lee Jones
2025-10-11 10:34 ` Greg KH
2025-10-21 10:56 ` Lee Jones
2025-10-21 11:25 ` Vlastimil Babka (SUSE)
2025-10-21 14:38 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251021143823.GH475031@google.com \
--to=lee@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).