patatt - tests source request

patatt - tests source request

[Mike Pagano]

[-- Attachment #1.1.1: Type: text/plain, Size: 411 bytes --]

Hello,

Would it be possible to include the entire "tests" directory in the 
release tarballs [1]?

Thanks,
Mike

[1] https://git.kernel.org/pub/scm/utils/patatt/patatt.git/tree/tests

-- 
Mike Pagano
Gentoo Developer
E-Mail     : mpagano@gentoo.org
GnuPG FP   : 52CC A0B0 F631 0B17 0142 F83F 92A6 DBEC 81F2 B137
Public Key : 
http://pgp.mit.edu/pks/lookup?search=0x92A6DBEC81F2B137&op=index


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 22141 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

Re: patatt - tests source request

[Konstantin Ryabitsev]

On Mon, Jan 05, 2026 at 09:53:59AM -0500, Mike Pagano wrote:
> Hello,
> 
> Would it be possible to include the entire "tests" directory in the release
> tarballs [1]?

Could you please clarify your request? The official release tarballs are built
directly from the git tag, so they should already include everything.

-K

Re: patatt - tests source request

[Mike Pagano]

On 1/5/26 11:25 AM, Konstantin Ryabitsev wrote:
> On Mon, Jan 05, 2026 at 09:53:59AM -0500, Mike Pagano wrote:
>> Hello,
>>
>> Would it be possible to include the entire "tests" directory in the release
>> tarballs [1]?
> 
> Could you please clarify your request? The official release tarballs are built
> directly from the git tag, so they should already include everything.
> 
> -K


Absolutely,

When I untar the 0.7.0 tarball (for instance), it does not have 
everything in the git repo in the tests directory.


0.7.0 has only test_validation.py in the tests directory.
If you look in the repo, there is much more in the tests directory.

Does that help?

Re: patatt - tests source request

[Konstantin Ryabitsev]

On Mon, Jan 05, 2026 at 11:40:12AM -0500, Mike Pagano wrote:
> When I untar the 0.7.0 tarball (for instance), it does not have everything
> in the git repo in the tests directory.
> 
> 0.7.0 has only test_validation.py in the tests directory.
> If you look in the repo, there is much more in the tests directory.

I'm not sure we're looking at the same tarballs:

    $ tar -tf patatt-0.7.0.tar.gz | grep '/tests/'
    patatt-0.7.0/tests/
    patatt-0.7.0/tests/__init__.py
    patatt-0.7.0/tests/conftest.py
    patatt-0.7.0/tests/test_validation.py
    patatt-0.7.0/tests/unit/
    patatt-0.7.0/tests/unit/__init__.py
    patatt-0.7.0/tests/unit/test_byhash.py
    patatt-0.7.0/tests/unit/test_devsig_header.py
    patatt-0.7.0/tests/unit/test_patatt_message.py

Did you download yours from here?
https://www.kernel.org/pub/software/devel/patatt/

-K

Re: patatt - tests source request

[Mike Pagano]

On 1/5/26 11:51 AM, Konstantin Ryabitsev wrote:
> On Mon, Jan 05, 2026 at 11:40:12AM -0500, Mike Pagano wrote:
>> When I untar the 0.7.0 tarball (for instance), it does not have everything
>> in the git repo in the tests directory.
>>
>> 0.7.0 has only test_validation.py in the tests directory.
>> If you look in the repo, there is much more in the tests directory.
> 
> I'm not sure we're looking at the same tarballs:
> 
>      $ tar -tf patatt-0.7.0.tar.gz | grep '/tests/'
>      patatt-0.7.0/tests/
>      patatt-0.7.0/tests/__init__.py
>      patatt-0.7.0/tests/conftest.py
>      patatt-0.7.0/tests/test_validation.py
>      patatt-0.7.0/tests/unit/
>      patatt-0.7.0/tests/unit/__init__.py
>      patatt-0.7.0/tests/unit/test_byhash.py
>      patatt-0.7.0/tests/unit/test_devsig_header.py
>      patatt-0.7.0/tests/unit/test_patatt_message.py
> 
> Did you download yours from here?
> https://www.kernel.org/pub/software/devel/patatt/
> 
> -K

Thanks, for your help.

No, we are downloading from:
https://pypi.org/project/patatt/#files

I will update our URLs to download from this URL.

Thanks again !

Re: patatt - tests source request

[Konstantin Ryabitsev]

On Mon, Jan 05, 2026 at 12:02:04PM -0500, Mike Pagano wrote:
> > Did you download yours from here?
> > https://www.kernel.org/pub/software/devel/patatt/
> > 
> No, we are downloading from:
> https://pypi.org/project/patatt/#files
> 
> I will update our URLs to download from this URL.

Hm... I'll check why pypi's files are different, but yes, please use the
official tarballs (that are signed, anyway).

-K

Re: patatt - tests source request

[Christian Heusel]

[-- Attachment #1: Type: text/plain, Size: 742 bytes --]

On 26/01/05 12:20PM, Konstantin Ryabitsev wrote:
> On Mon, Jan 05, 2026 at 12:02:04PM -0500, Mike Pagano wrote:
> > > Did you download yours from here?
> > > https://www.kernel.org/pub/software/devel/patatt/
> > > 
> > No, we are downloading from:
> > https://pypi.org/project/patatt/#files
> > 
> > I will update our URLs to download from this URL.
> 
> Hm... I'll check why pypi's files are different, but yes, please use the
> official tarballs (that are signed, anyway).
> 
> -K

The sdist tarballs hosted on pypi are apparently often times different
from the "regular" tarballs, which is why we default to not using them
on Arch Linux:

https://rfc.archlinux.page/0020-sources-for-python-packaging/

Cheers,
Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]