Re: [PATCH b4 2/2] b4: add support for oauth2 SMTP authentication

[Konstantin Ryabitsev <konstantin@linuxfoundation.org>]

On Mon, Feb 02, 2026 at 06:49:09PM +0200, Tomas Melin wrote:
> > Any reason we're not making use of git_credential_fill() here? I'm not sure we
> > can expect correct return here, because credential helpers expect input on
> > stdin like:
> > 
> >   protocol=smtp
> >   host=<server>
> >   username=<user>
> > 
> > The existing git_credential_fill() function should already handle this
> > correctly, unless I'm mistaken or you have other reasons not to use it.
> 
> Adding to my previous reply, this integration aligns with
> https://git-scm.com/docs/gitcredentials and in particular
> https://git-scm.com/docs/gitcredentials#_custom_helpers
> 
> And in identical manner as git-send-email this uses external helpers
> like listed here https://git-scm.com/docs/git-send-email#_sending_patches
> 
> So I don't see that git_credential_fill would be a match for it.

Sounds good to me, thank you for doing the extra legwork. I will be happy to
review v2 once you send it in with the other fixes.

-K