public inbox for tools@linux.kernel.org
 help / color / mirror / Atom feed
* odd b4 "Mail:" trailer added for USB patch
       [not found] <20191024205803.qdn6p32iyj5rqvc6@chatter.i7.local>
@ 2026-02-06 10:21 ` Greg KH
  2026-02-06 14:32   ` Konstantin Ryabitsev
                     ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Greg KH @ 2026-02-06 10:21 UTC (permalink / raw)
  To: tools

When running the following command that I normally do to apply patches:
	b4 am -S -t -o - | git am -s
from my email client, for the patch with:
	Message-ID: <20260206-wip-jremmet-hd3ss3220_vbus_split-v4-1-ee5b4e402187@phytec.de>

I get:

Looking up https://lore.kernel.org/all/20260206-wip-jremmet-hd3ss3220_vbus_split-v4-1-ee5b4e402187@phytec.de/
Analyzing 1 messages in the thread
Analyzing 11 code-review messages
Checking attestation on all messages, may take a moment...
---
  ✓ [PATCH v4] usb: typec: hd3ss3220: Check if regulator needs to be switched
 be switched") (✓ DKIM/phytec.de)typec: hd3ss3220: Check if regulator needs to
    + Mail: j.remmet@pyhtec.de (✓ DKIM/phytec.de)
  ---
  ✓ Signed: DKIM/phytec.de
---
Total patches: 1
---
 Link: https://patch.msgid.link/20260206-wip-jremmet-hd3ss3220_vbus_split-v4-1-ee5b4e402187@phytec.de
 Base: applies clean to current tree
Applying: usb: typec: hd3ss3220: Check if regulator needs to be switched


It's that odd "Mail:" header being added, which then shows up in the
commit itself:

    Fixes: 27fbc19e52b9 ("usb: typec: hd3ss3220: Enable VBUS based on role state")
    Signed-off-by: Jan Remmet <j.remmet@phytec.de>
    Reviewed-by: Heikki Krogerus <heikki.krogerus@linu.intel.com>
    Fixes: 7e7025811579 ("usb: typec: hd3ss3220: Check if regulator needs to ^M be switched")
    Mail: j.remmet@pyhtec.de
    Link: https://patch.msgid.link/20260206-wip-jremmet-hd3ss3220_vbus_split-v4-1-ee5b4e402187@phytec.de
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Along with the extra "^M" in there (actual character) in the Fixes tag?

I'm using the latest git version of b4:

$ b4 --version
0.15-dev-47773

Any ideas?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: odd b4 "Mail:" trailer added for USB patch
  2026-02-06 10:21 ` odd b4 "Mail:" trailer added for USB patch Greg KH
@ 2026-02-06 14:32   ` Konstantin Ryabitsev
  2026-03-06  0:23   ` Konstantin Ryabitsev
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Konstantin Ryabitsev @ 2026-02-06 14:32 UTC (permalink / raw)
  To: Greg KH; +Cc: tools

On Fri, Feb 06, 2026 at 11:21:43AM +0100, Greg KH wrote:
> When running the following command that I normally do to apply patches:
> 	b4 am -S -t -o - | git am -s
> from my email client, for the patch with:
> 	Message-ID: <20260206-wip-jremmet-hd3ss3220_vbus_split-v4-1-ee5b4e402187@phytec.de>
> 
> I get:
> 
> Looking up https://lore.kernel.org/all/20260206-wip-jremmet-hd3ss3220_vbus_split-v4-1-ee5b4e402187@phytec.de/
> Analyzing 1 messages in the thread
> Analyzing 11 code-review messages
> Checking attestation on all messages, may take a moment...
> ---
>   ✓ [PATCH v4] usb: typec: hd3ss3220: Check if regulator needs to be switched
>  be switched") (✓ DKIM/phytec.de)typec: hd3ss3220: Check if regulator needs to
>     + Mail: j.remmet@pyhtec.de (✓ DKIM/phytec.de)

Sigh. This happens occasionally, because we can't have a strict list of
trailers we recognize for follow-ups (because of people's proclivity to use
things like Suggested-and-co-developed-by: or whatnot). We have a junklist of
things we know are bogus, but every now and again there's something we haven't
thought of (like people using "Mail" instead of "Email").

I'll add this to the junklist as well.

-K

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: odd b4 "Mail:" trailer added for USB patch
  2026-02-06 10:21 ` odd b4 "Mail:" trailer added for USB patch Greg KH
  2026-02-06 14:32   ` Konstantin Ryabitsev
@ 2026-03-06  0:23   ` Konstantin Ryabitsev
  2026-03-06  0:25   ` B4 Bugbot
  2026-03-06 19:34   ` B4 Bugbot
  3 siblings, 0 replies; 5+ messages in thread
From: Konstantin Ryabitsev @ 2026-03-06  0:23 UTC (permalink / raw)
  To: Greg KH; +Cc: tools

On Fri, Feb 06, 2026 at 11:21:43AM +0100, Greg KH wrote:
>   ✓ [PATCH v4] usb: typec: hd3ss3220: Check if regulator needs to be switched
>  be switched") (✓ DKIM/phytec.de)typec: hd3ss3220: Check if regulator needs to
>     + Mail: j.remmet@pyhtec.de (✓ DKIM/phytec.de)

bugspray tag b4/trailers

-- 
KR

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: odd b4 "Mail:" trailer added for USB patch
  2026-02-06 10:21 ` odd b4 "Mail:" trailer added for USB patch Greg KH
  2026-02-06 14:32   ` Konstantin Ryabitsev
  2026-03-06  0:23   ` Konstantin Ryabitsev
@ 2026-03-06  0:25   ` B4 Bugbot
  2026-03-06 19:34   ` B4 Bugbot
  3 siblings, 0 replies; 5+ messages in thread
From: B4 Bugbot @ 2026-03-06  0:25 UTC (permalink / raw)
  To: gregkh, bugbot+b4, tools

Hello:

This conversation is now tracked by b4 bug tracker.
There is no need to do anything else, just keep talking.

--
Deet-doot-dot, I am a bot.
b4 bug tracker (bugspray 0.1-dev)


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: odd b4 "Mail:" trailer added for USB patch
  2026-02-06 10:21 ` odd b4 "Mail:" trailer added for USB patch Greg KH
                     ` (2 preceding siblings ...)
  2026-03-06  0:25   ` B4 Bugbot
@ 2026-03-06 19:34   ` B4 Bugbot
  3 siblings, 0 replies; 5+ messages in thread
From: B4 Bugbot @ 2026-03-06 19:34 UTC (permalink / raw)
  To: mricon, gregkh, tools

Konstantin Ryabitsev writes in commit 002f70670507a3edca307edd11b5e0000d9d73a2:

Add 'mail' to the known non-trailer ignore list

A code-review follow-up containing "Mail: someone@example.com" was
being picked up as a valid trailer and injected into the commit.
Add 'mail' to the ignore set alongside the already-ignored 'phone',
'email', and 'e-mail' entries so it is silently skipped during
follow-up trailer collection.

Closes: https://msgid.link/2026020637-cleft-viscosity-c984@gregkh # cd06df9
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Assisted-by: claude-opus-4-6

--
Deet-doot-dot, I am a bot.
b4 bug tracker (bugspray 0.1-dev)


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-03-06 19:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20191024205803.qdn6p32iyj5rqvc6@chatter.i7.local>
2026-02-06 10:21 ` odd b4 "Mail:" trailer added for USB patch Greg KH
2026-02-06 14:32   ` Konstantin Ryabitsev
2026-03-06  0:23   ` Konstantin Ryabitsev
2026-03-06  0:25   ` B4 Bugbot
2026-03-06 19:34   ` B4 Bugbot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox