Missing cover letter

Missing cover letter

[Dave Hansen]

b4 am doesn't seem to like my cover letter:

https://lore.kernel.org/all/20260213235119.6A9A0F80@davehans-spike.ostc.intel.com/

I think it's because I didn't put a diffstat in that cover letter (it didn't get sent with git send-email). I even hacked:

-        if DIFFSTAT_RE.search(self.body):
-            self.has_diffstat = True
+        self.has_diffstat = True

and the cover letter is showing up now.

Any chance b4 could use a different heuristic for determining cover letters? Or should I stop being lazy and fix my script? :)

Re: Missing cover letter

[Kees Cook]

On Tue, Feb 24, 2026 at 01:22:47PM -0800, Dave Hansen wrote:
> I think it's because I didn't put a diffstat in that cover letter (it didn't get sent with git send-email). I even hacked:

I kinda think cover letters should always have a diffstat ... :P

FWIW, I use: git format-patch --cover-letter -n -o outgoing/ ...

-- 
Kees Cook

Re: Missing cover letter

[Dave Hansen]

On 2/24/26 14:16, Kees Cook wrote:
> On Tue, Feb 24, 2026 at 01:22:47PM -0800, Dave Hansen wrote:
>> I think it's because I didn't put a diffstat in that cover letter
>> (it didn't get sent with git send-email). I even hacked:
> I kinda think cover letters should always have a diffstat ... :P

Yeah, I agree and I actually already fixed my scripts to add one. But it
did surprise me, and it might surprise anyone who composes a series
without git.

Handling it would definitely be helpful to a minority of folks.

Re: Missing cover letter

[Konstantin Ryabitsev]

On Tue, Feb 24, 2026 at 01:22:47PM -0800, Dave Hansen wrote:
> b4 am doesn't seem to like my cover letter:
> 
> https://lore.kernel.org/all/20260213235119.6A9A0F80@davehans-spike.ostc.intel.com/

That's because your cover letter has [v3] but none of the patches do:

    2026-02-13 23:51 [PATCH 0/4] [v3] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
    2026-02-13 23:51 ` [PATCH 1/4] x86/microcode: Refactor platform ID enumeration into a helper Dave Hansen
    2026-02-13 23:51 ` [PATCH 2/4] x86/cpu: Add platform ID to CPU info structure Dave Hansen
    2026-02-13 23:51 ` [PATCH 3/4] x86/cpu: Add platform ID to CPU matching structure Dave Hansen
    2026-02-13 23:51 ` [PATCH 4/4] x86/microcode: Add platform mask to Intel microcode "old" list Dave Hansen

Pretty much any assumption we try to make here is going to be wrong for some
other case, so I'm just going to politely ask to please number your patches
as git/b4/any other tool expects them. :)

-- 
KR

Re: Missing cover letter

[Dave Hansen]

On 2/24/26 16:17, Konstantin Ryabitsev wrote:
> That's because your cover letter has [v3] but none of the patches do:
> 
>     2026-02-13 23:51 [PATCH 0/4] [v3] x86/cpu: Take Intel platform into account for old microcode checks Dave Hansen
>     2026-02-13 23:51 ` [PATCH 1/4] x86/microcode: Refactor platform ID enumeration into a helper Dave Hansen
>     2026-02-13 23:51 ` [PATCH 2/4] x86/cpu: Add platform ID to CPU info structure Dave Hansen
>     2026-02-13 23:51 ` [PATCH 3/4] x86/cpu: Add platform ID to CPU matching structure Dave Hansen
>     2026-02-13 23:51 ` [PATCH 4/4] x86/microcode: Add platform mask to Intel microcode "old" list Dave Hansen
> 
> Pretty much any assumption we try to make here is going to be wrong for some
> other case, so I'm just going to politely ask to please number your patches
> as git/b4/any other tool expects them. 🙂

Ahh, that's fair and very fixable. Thanks for the suggestion!