Re: b4 review available in master

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 11682 bytes --]

On Sat, Feb 28, 2026 at 11:57:09AM -0500, Konstantin Ryabitsev wrote:
> On Sat, Feb 28, 2026 at 04:48:58PM +0000, Conor Dooley wrote:
> > > I put a fix into latest master for this particular one. Thanks!
> > 
> > Seems like you got half the problem? Certainly predictive on the "more
> > places though! ;)
> 
> Indeed. I put the escaping into a bunch of other places, too, where we can
> reasonably expect [] syntax from subject prefixes and such. Try it out in the
> latest master.

$ /stuff/b4/b4.sh review tui -i linux-dt
╭────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── Traceback (most recent call last) ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╮
│ /stuff/b4/src/b4/review_tui/_review_app.py:219 in on_mount                                                                                                                                                                                                                             │
│                                                                                                                                                                                                                                                                                        │
│    216 │                                                                                        ╭─────────────────────────────────────────── locals ────────────────────────────────────────────╮                                                                                      │
│    217 │   def on_mount(self) -> None:                                                          │ self = ReviewApp(title='b4 review', classes={'-dark-mode'}, pseudo_classes={'dark', 'focus'}) │                                                                                      │
│    218 │   │   self._refresh_newer_warning()                                                    ╰───────────────────────────────────────────────────────────────────────────────────────────────╯                                                                                      │
│ ❱  219 │   │   self._refresh_title_bar()                                                                                                                                                                                                                                               │
│    220 │   │   self._populate_patch_list()                                                                                                                                                                                                                                             │
│    221 │   │   self._show_content(self._selected_idx)                                                                                                                                                                                                                                  │
│    222                                                                                                                                                                                                                                                                                 │
│                                                                                                                                                                                                                                                                                        │
│ /stuff/b4/src/b4/review_tui/_review_app.py:235 in _refresh_title_bar                                                                                                                                                                                                                   │
│                                                                                                                                                                                                                                                                                        │
│    232 │   │   else:                                                                            ╭───────────────────────────────────────────── locals ─────────────────────────────────────────────╮                                                                                   │
│    233 │   │   │   label = f' \u270e {subject}'                                                 │     bar = Static(id='title-bar')                                                                 │                                                                                   │
│    234 │   │   │   bar.styles.background = self.get_css_variables()['primary-darken-2']         │   label = ' ✎ [PATCH v5 1/8] iommu/riscv: Enable IOMMU DMA mapping support'                      │                                                                                   │
│ ❱  235 │   │   bar.update(label)                                                                │    self = ReviewApp(title='b4 review', classes={'-dark-mode'}, pseudo_classes={'dark', 'focus'}) │                                                                                   │
│    236 │                                                                                        │ subject = '[PATCH v5 1/8] iommu/riscv: Enable IOMMU DMA mapping support'                         │                                                                                   │
│    237 │   def _refresh_newer_warning(self) -> None:                                            ╰──────────────────────────────────────────────────────────────────────────────────────────────────╯                                                                                   │
│    238 │   │   """Show or hide the newer-version warning bar based on tracking data."""                                                                                                                                                                                                │
│                                                                                                                                                                                                                                                                                        │
│ /usr/lib/python3/dist-packages/textual/widgets/_static.py:106 in update                                                                                                                                                                                                                │
│                                                                                                                                                                                                                                                                                        │
│   103 │   │   """                                                                              ╭────────────────────────────────── locals ───────────────────────────────────╮                                                                                                         │
│   104 │   │                                                                                    │ content = ' ✎ [PATCH v5 1/8] iommu/riscv: Enable IOMMU DMA mapping support' │                                                                                                         │
│   105 │   │   self._content = content                                                          │    self = Static(id='title-bar')                                            │                                                                                                         │
│ ❱ 106 │   │   self._visual = visualize(self, content, markup=self._render_markup)              ╰─────────────────────────────────────────────────────────────────────────────╯                                                                                                         │
│   107 │   │   self.refresh(layout=True)                                                                                                                                                                                                                                                │
│   108                                                                                                                                                                                                                                                                                  │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯
MarkupError: Expected markup style value (found '1/8] iommu/riscv: Enable IOMMU DMA mapping support').

NOTE: 1 of 2 errors shown. Run with textual run --dev to see all errors.


Am I just cursed? This is on 9ca5b4f review: escape remaining user strings passed to markup-enabled widgets

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]