Re: b4 review available in master

Conor Dooley
2026-03-04T21:38:13Z

[-- Attachment #1: Type: text/plain, Size: 2901 bytes --]

On Tue, Mar 03, 2026 at 12:16:18AM -0500, Konstantin Ryabitsev wrote:
> On Sat, Feb 28, 2026 at 10:32:04PM +0000, Conor Dooley wrote:

> > I feel like I am spamming you with responses here, sorry about that!
>
> Please continue! There's also a hopefully-noticeable notification when you're
> running the review tui from a review branch that will tell you how to get back
> to the series tracking view. :)

I tried again today to use it but ran into some things flow wise, that
prevented me from actually doing any reviewing.

Firstly, with the patchwork pane, how do I determine which states
appear? Most things get set by a bot to "needs ack" in the dt patchwork,
but I only see things as "under review" or "new" in the pane. We use
"under review" to mean the bot is looking at it mainly and "needs ack"
for stuff that humans need to look at, so I need to figure out how to
display things with that status. Pretty much this is "your default view
doesn't match the default patchwork view (State = Action Required)".

Secondly, if I'm working from a patchwork, it'd be really great if I
could reply to patches directly from the patchwork pane. 90% of patches
I review (or more) I do not need to apply, so working in mutt is
significantly faster than having to track, then open in a different
pane. Related to that, being able to display the patchwork pane
per-patch as an option would be a wishlist item to make this replace
mutt for me.

That's from a dt-bindings review perspective though, how these things
work is fine (bugs aside) where I am the person applying patches. It's
probably far from the end of the world if dt-binding stuff stays in
mutt, since it's probably atypical.

Oh, and I managed to trigger a formatting bug again, on 0.15-dev-54639

MissingStyle: Failed to get style 'v2,1/2'; unable to parse 'v2,1/2' as color; 'v2,1/2' is not a valid color

after grabbing a series from patchwork

/stuff/b4/b4.sh review tui -i linux-dt
Retrieving series: <20260212082105.1878720-2-sh86.bae@samsung.com>

It creates a massive spam of text, but it contains:
text = <text 'Started tracking: dt-bindings: soc: samsung: exynos-sysreg: Add hsi0 for ExynosAutov920' [Span(18, 88, 'v2,1/2')] ''>

LMK if you require the full log for this.

Pretty sure I replicated it on 0.15-dev-18f8f too, but I'm not entirely
sure as I cannot untrack series to retest.

I also hit some weird interaction, where after hitting track on a load
of stuff in the patchwork pane, nothing shows up in my review pane, but
it looks like it should have appeared:
/stuff/b4/b4.sh review tui -i linux-dt
Retrieving series: <20260220-ayn-vendor-v1-1-292cbbb682b3@gmail.com>
Looking up https://lore.kernel.org/all/20260220-ayn-vendor-v1-1-292cbbb682b3@gmail.com/
Grabbing thread from lore.kernel.org/all/20260220-ayn-vendor-v1-1-292cbbb682b3@gmail.com/t.mbox.gz

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]