Re: b4 review available in master

Conor Dooley
2026-02-28T22:32:07Z

[-- Attachment #1: Type: text/plain, Size: 2042 bytes --]

On Sat, Feb 28, 2026 at 10:16:15PM +0000, Conor Dooley wrote:
> On Sat, Feb 28, 2026 at 12:34:40PM -0500, Konstantin Ryabitsev wrote:
> > On Sat, Feb 28, 2026 at 12:21:27PM -0500, Konstantin Ryabitsev wrote:
> > > Argh, escape_markup will, unhelpfully, only escape actual markup. So, it will
> > > escape [bold] into \[bold\] but leave [PATCH] as [PATCH]. WTF, who decided
> > > this was a good idea?
> > >
> > > I'll commit a more wholesome fix shortly, sorry about that.
> >
> > OK, the more wholesome fix is in place now. Please try it out and hopefully
> > that lifts the curse.
>
> Yeah, got me further but I got stuck again - although not on a crash. I
> sent you a mail with a screenshot of where I am :)
>
> One thing I noticed was missing was that I have no idea while looking at
> a patch who sent it. If you look at the mail I sent with the screenshot:
> Lv Zheng is the submitter, so the signoff chain is wrong (cos there's no
> from header in the patch to make Jingyu the author, so either there's a
> co-developed-by missing or a from header is needed), but it's impossible
> to tell from this UI. Once you hit "reply", then you can see it, but not
> from the main view.
>
> I have some other thoughts that are half baked, and I will try to
> elaborate on them once I have at least tried to do a days review with
> the tool.

I found another issue. I tried to use it to send an email:
https://lore.kernel.org/all/177231592262.848068.18080490567217057666@spud/
The tool decided to send it from "Conor Dooley <conor.dooley@microchip.com>"
by that's not the from field in my gitconfig, but it is what my
user.email is:

| $ git config get sendemail.from
| Conor Dooley <conor@kernel.org>
| $ git config get user.email
| conor.dooley@microchip.com

Obviously this caused a bunch of rejections due to DMARC issues, because
it used the kernel.org email server setup from my gitconfig with my work
address.

I feel like I am spamming you with responses here, sorry about that!

Conor.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]