Re: b4 review available in master

Mark Brown
2026-03-18T13:00:40Z

[-- Attachment #1: Type: text/plain, Size: 1181 bytes --]

On Wed, Mar 18, 2026 at 08:56:56AM +0100, Geert Uytterhoeven wrote:
> On Wed, 18 Mar 2026 at 00:37, Konstantin Ryabitsev <mricon@kernel.org> wrote:

> > However, I am now curious to hear your feedback. The idea with the review app
> > is that you are not really sending an email, you're adding comments to code
> > and adding review trailers. The app will render and send that out for you,
> > trimming and formatting things nicely so you don't have to do it on your own

> I haven't tried b4 review yet, but how do you decide what (not) to trim?
> It is not uncommon to explicitly not trim some parts, as they are important
> to understand the comment on a seemingly unrelated part.

I also find that it's frequently useful to trim things while writing a
reply to a patch to make the message more managable and show what bits
still need commenting on.

> > (I've noticed that many maintainers don't bother anyway -- there are emails
> > with a terse comment at the top and then a huge quoted bottom that is only
> > followed by their sig.

> IMHO this is very bad behavior: not trimming replies forces everyone
> to skim the remainder for more comments.

It's extremely annoying.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]