Re: b4 review available in master

Jonathan Corbet
2026-03-17T21:46:11Z

Konstantin Ryabitsev <mricon@kernel.org> writes:

> On Tue, Mar 17, 2026 at 10:23:33AM -0400, Konstantin Ryabitsev wrote:
>> > If I've done everything right, you'll find what you're looking for at
>> >
>> > git://git.lwn.net/linux.git b4/review/20260312-kernel-doc-use-a-c-lexical-tokenizer-for-transforms-0e0e9e143327
>>
>> Yep, found it. *sigh*
>>
>> Unfortunately, it's not an easy fix. I think I'll have to
>> abandon how we currently do inline comments -- the diff format is just too
>> fragile to try to intersperse it with comments. I think I'm just going to load
>> the diff using standard "> " quoting instead of trying to be creative with >>>
>> <<< markers. Maintainers are more used to seeing that anyway.
>>
>> I'll let you know when the new code is ready for testing.
>
> Okay, a fairly big change landed in master that completely does away with "C"
> and inline comments. You now just hit "r" to reply and add your comments just
> like you would to any other message -- benefiting from your existing mastery
> of your preferred editor.
>
> We also ship vim and emacs syntax files in misc/ -- they make it easier to
> reply to diffs than regular email syntax styling.
>
> Please try it out again. Your old bugs should be gone and replaced by whole
> new bugs!

So it's still behaving a bit strangely, at least that's how it seems to
me. I tried adding comments to a patch, doing my usual trick of
trimming out stuff that is being skipped over. Quitting that, then
asking for email mode showed me a blank message, which is rather more
terse than I usually am.

So I went and did it again, simply inserting a comment in the patch
without removing anything, but it still shows up in the wrong place. I
guess it just doesn't like me...?

(I can push another branch on request).

jon