public inbox for tools@linux.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Konstantin Ryabitsev <mricon@kernel.org>
Cc: users@kernel.org, tools@kernel.org
Subject: Re: b4 review available in master
Date: Sat, 28 Feb 2026 13:31:04 -0500	[thread overview]
Message-ID: <20260228125823-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20260227-imported-aromatic-guppy-ad3dca@lemur>

On Fri, Feb 27, 2026 at 02:53:07PM -0500, Konstantin Ryabitsev wrote:
>   - AI-assisted review using an external agent (Claude Code, Gemini CLI,
>     OpenAI Codex CLI, GitHub Copilot CLI) — agent findings are private to the
>     maintainer and can then be selectively incorporated into the review
>   - Patchwork integration: browse series, view CI check results, track series
>     directly from Patchwork, and automatically synchronise Patchwork state as
>     you work
> 
> Watch the screencasts in the link above if you're curious and please try it
> out. I'm sure there is a ton of corner cases that are not properly handled
> right now, so the more feedback I receive, the better.
> 
> If you want to play with LLM reviews, you will need to specifically configure
> your agent. See docs for that. If you don't have a subscription available, I
> am told that there is a program for OSS maintainers available:
> 
> https://claude.com/contact-sales/claude-for-oss
> 
> If you know of a similar program offered by other LLM providers, I'll be happy
> to know about it. I've tested claude, gemini-cli and codex. (I did test using
> ollama-based agents a while back, but the results were a very mixed bag --
> there is usually not enough context available to these models to perform a
> useful code review, but ymmv.)
> 
> Best regards,
> -- 
> KR

Amazing, thanks for working on this.


But I could not get it to work with gemini:
I have:

    [b4]
      review-agent-command = gemini --sandbox --allowed-tools 'Bash(git:*) Read Glob Grep Write(.git/b4-review/**) Edit(.git/b4-review/**)'
      review-agent-prompt-path = .git/agent-reviewer.md


and this runs:

gemini --sandbox --allowed-tools Bash(git:*) Read Glob Grep Write(.git/b4-review/**) Edit(.git/b4-review/**) -- Read the prompt from /scm/b4/.git/agent-reviewer.md


But this just gets me an interactive prompt:


Running review agent: gemini --sandbox --allowed-tools Bash(git:*) Read Glob Grep Write(.git/b4-review/**) Edit(.git/b4-review/**) -- Read the prompt from /scm/b4/.git/agent-reviewer.md

 ███            █████████  ██████████ ██████   ██████ █████ ██████   █████ █████
░░░███         ███░░░░░███░░███░░░░░█░░██████ ██████ ░░███ ░░██████ ░░███ ░░███
  ░░░███      ███     ░░░  ░███  █ ░  ░███░█████░███  ░███  ░███░███ ░███  ░███
    ░░░███   ░███          ░██████    ░███░░███ ░███  ░███  ░███░░███░███  ░███
     ███░    ░███    █████ ░███░░█    ░███ ░░░  ░███  ░███  ░███ ░░██████  ░███
   ███░      ░░███  ░░███  ░███ ░   █ ░███      ░███  ░███  ░███  ░░█████  ░███
 ███░         ░░█████████  ██████████ █████     █████ █████ █████  ░░█████ █████
░░░            ░░░░░░░░░  ░░░░░░░░░░ ░░░░░     ░░░░░ ░░░░░ ░░░░░    ░░░░░ ░░░░░


Authenticated with gemini-api-key /auth
Tips for getting started:
1. Ask questions, edit files, or run commands.
2. Be specific for the best results.
3. Create GEMINI.md files to customize your interactions with Gemini.
4. /help for more information.

⚠  Warning: --allowed-tools cli argument and tools.allowed in settings.json are deprecated and will be removed in 1.0: Migrate to Policy
   Engine: https://geminicli.com/docs/core/policy-engine/
                                                                                                                         ? for shortcuts 
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 shift+tab to accept edits                                                                                                       1 skill
▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀▀
 >   Type your message or @path/to/file                                                                                                  
▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄
 /scm/b4 (b4/review/20251013-b4-sparse-checkout-related-fixes-bad772cc2a80*)           sandbox-0.31.0-2           /model Auto (Gemini 3)



Thanks!
-- 
MST


  parent reply	other threads:[~2026-02-28 18:31 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 19:53 b4 review available in master Konstantin Ryabitsev
2026-02-28 15:12 ` Mark Brown
2026-02-28 15:47   ` Konstantin Ryabitsev
2026-02-28 16:00     ` Konstantin Ryabitsev
2026-02-28 18:12       ` Mark Brown
2026-02-28 15:53 ` Mark Brown
2026-02-28 21:11   ` Mark Brown
2026-03-03  5:14     ` Konstantin Ryabitsev
2026-03-03 12:42       ` Mark Brown
2026-03-03 18:21         ` Konstantin Ryabitsev
2026-03-12 17:21           ` Alexandre Belloni
2026-03-13 15:42             ` Konstantin Ryabitsev
2026-03-13 15:55               ` Alexandre Belloni
2026-03-21 10:01                 ` Alexandre Belloni
2026-03-12 17:35           ` Mark Brown
2026-03-13 15:42             ` Konstantin Ryabitsev
2026-02-28 16:36 ` Conor Dooley
2026-02-28 16:45   ` Konstantin Ryabitsev
2026-02-28 16:48     ` Conor Dooley
2026-02-28 16:57       ` Konstantin Ryabitsev
2026-02-28 17:00         ` Conor Dooley
2026-02-28 17:05           ` Konstantin Ryabitsev
2026-02-28 17:12             ` Conor Dooley
2026-02-28 17:21               ` Konstantin Ryabitsev
2026-02-28 17:34                 ` Konstantin Ryabitsev
2026-02-28 18:37                   ` Conor Dooley
2026-02-28 22:16                   ` Conor Dooley
2026-02-28 22:32                     ` Conor Dooley
2026-03-03  5:16                       ` Konstantin Ryabitsev
2026-03-04 21:38                         ` Conor Dooley
2026-03-04 22:40                           ` Konstantin Ryabitsev
2026-03-04 22:55                             ` Conor Dooley
2026-03-05  3:26                               ` Konstantin Ryabitsev
2026-03-05  6:17                             ` Konstantin Ryabitsev
2026-02-28 18:31 ` Michael S. Tsirkin [this message]
2026-02-28 20:06   ` Konstantin Ryabitsev
2026-02-28 20:23     ` Michael S. Tsirkin
2026-02-28 20:37       ` Konstantin Ryabitsev
2026-02-28 20:47         ` Michael S. Tsirkin
2026-02-28 20:53           ` Konstantin Ryabitsev
2026-02-28 21:04             ` Michael S. Tsirkin
2026-03-02  9:30 ` Michael S. Tsirkin
2026-03-02 10:33 ` Michael S. Tsirkin
2026-03-03  1:58 ` Junio C Hamano
2026-03-03  4:26   ` Konstantin Ryabitsev
2026-03-03 11:20     ` Matthieu Baerts
2026-03-04 20:56 ` range-diff hangs Marc Kleine-Budde
2026-03-14  4:20   ` Konstantin Ryabitsev
2026-03-14  9:27     ` Marc Kleine-Budde
2026-03-16 23:28 ` b4 review available in master Jonathan Corbet
2026-03-16 23:41   ` Jonathan Corbet
2026-03-17  0:15     ` Konstantin Ryabitsev
2026-03-17 14:11       ` Jonathan Corbet
2026-03-17 14:23         ` Konstantin Ryabitsev
2026-03-17 20:30           ` Konstantin Ryabitsev
2026-03-17 21:46             ` Jonathan Corbet
2026-03-17 22:39               ` Konstantin Ryabitsev
2026-03-17 23:37                 ` Konstantin Ryabitsev
2026-03-18  7:56                   ` Geert Uytterhoeven
2026-03-18 13:00                     ` Mark Brown
2026-03-18 13:26                     ` Konstantin Ryabitsev
2026-03-18 16:47                   ` Jonathan Corbet
2026-03-18 18:31                     ` Laurent Pinchart
2026-03-18 19:22                     ` Konstantin Ryabitsev
2026-03-17  0:12   ` Konstantin Ryabitsev
2026-03-18 13:43   ` Johannes Thumshirn
2026-03-20 16:53 ` Louis Chauvet
2026-03-20 19:31   ` Konstantin Ryabitsev
2026-03-20 21:14     ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260228125823-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=mricon@kernel.org \
    --cc=tools@kernel.org \
    --cc=users@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox