public inbox for tools@linux.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Konstantin Ryabitsev <mricon@kernel.org>
Cc: users@kernel.org, tools@kernel.org
Subject: Re: b4 review available in master
Date: Mon, 2 Mar 2026 04:30:49 -0500	[thread overview]
Message-ID: <20260302035403-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20260227-imported-aromatic-guppy-ad3dca@lemur>

On Fri, Feb 27, 2026 at 02:53:07PM -0500, Konstantin Ryabitsev wrote:
> Hi, all:
> 
> TLDR: "b4 review" is a terminal UI that hopes to streamline a lot of
> maintainer duties. A getting-started guide with screencasts is here:
> https://b4.docs.kernel.org/en/latest/reviewer/getting-started.html
> 
> It's available from b4 master pending initial testing and will be generally
> available in b4-0.15.


OK I just tried the "update" flow, and maybe it worked, thanks!
Though I was confused for a while.
I had this:


Date        Status       Submitter                      Subject                                                                          
2026-02-28  reviewing    Vishwanath Seshagiri           virtio_net: add page_pool support for buffer allocation                          
2025-10-13  new          Michael S. Tsirkin             b4: sparse-checkout related fixes                                                
                                                                                                                                         
                                                                                                                                         
    (... lots of empty lines ...)
                                                                                                                                         
                                                                                                                                         
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
 Subject:    [v8,0/1] virtio_net: add page_pool support for buffer allocation                                                            
 From:       Vishwanath Seshagiri <vishs@meta.com>                                                                                       
 Sent:       Sat, 28 Feb 2026 08:41:22 -0500                                                                                             
 Change-ID:  20260228-virtio_net-add-page_pool-support-for-buffer-allocation-6273c5614ede                                                
 Link:       https://patch.msgid.link/20260228134122.631580-1-vishs@meta.com                                                             
 Revisions:  v2, v3, v4, v5, v6, v7, v8, v9 (upgrade from v8 with [a]ction)                                                              
 A/R/T:      - / - / -                                                                                                                   
 Branch:     b4/review/20260228-virtio_net-add-page_pool-support-for-buffer-allocation-6273c5614ede                                      
 r review  d range-diff  a action ▏ u update  l limit  s shell  q quit  ? help                                               ▏^p palette 




So I was confused: I can see there is a v9 but why is it still showing me v8?
It took me a while until I noticed Revisions below and a while more
until I understood: this is intentional,
it means that yes it is v8 but v9 is available and if I press action
I can upgrade. Maybe putting a * near the current revision will help.
Maybe adding (upgrade to v9 with [a]ction) near v8 in the subject will
help.
Maybe showing "press a for [a]ction now to apply the upgrade" will help.

Maybe automatically triggering the correct action is the right thing?
I wonder why not.

"action" is also very generic. Maybe saying More [a]ctions in the menu will
better hint to the user it's like a ... and worth exploring.

Then I did "a" and I got a list of options none of which is "update"
or mentions v8 or v9. I guessed "rebase review branch" does it
and it seems to, but I have no idea why and what rebase
does it refer to:
                                              ┌───────────────────────────────────────────┐                                              
                                              │                                           │                                              
                                              │  Select action:                           │                                              
                                              │  Take (apply to branch)                   │                                              
                                              │  Rebase review branch                     │                                              
                                              │  Mark as waiting on new revision          │                                              
                                              │  Abandon series                           │                                              
                                              │  Archive series                           │                                              
                                              │                                           │                                              
                                              └───────────────────────────────────────────┘                                              
                 
does it always update to latest revision? rename accordingly?
also actually saying what is rebased to what in the menu would have
helped.
                                                                                                                        

Overall I was able to figure out things, and it worked!
The notes are here to maybe polish the UI even more.
Thanks!

-- 
MST



  parent reply	other threads:[~2026-03-02  9:30 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 19:53 b4 review available in master Konstantin Ryabitsev
2026-02-28 15:12 ` Mark Brown
2026-02-28 15:47   ` Konstantin Ryabitsev
2026-02-28 16:00     ` Konstantin Ryabitsev
2026-02-28 18:12       ` Mark Brown
2026-02-28 15:53 ` Mark Brown
2026-02-28 21:11   ` Mark Brown
2026-03-03  5:14     ` Konstantin Ryabitsev
2026-03-03 12:42       ` Mark Brown
2026-03-03 18:21         ` Konstantin Ryabitsev
2026-03-12 17:21           ` Alexandre Belloni
2026-03-13 15:42             ` Konstantin Ryabitsev
2026-03-13 15:55               ` Alexandre Belloni
2026-03-21 10:01                 ` Alexandre Belloni
2026-03-12 17:35           ` Mark Brown
2026-03-13 15:42             ` Konstantin Ryabitsev
2026-02-28 16:36 ` Conor Dooley
2026-02-28 16:45   ` Konstantin Ryabitsev
2026-02-28 16:48     ` Conor Dooley
2026-02-28 16:57       ` Konstantin Ryabitsev
2026-02-28 17:00         ` Conor Dooley
2026-02-28 17:05           ` Konstantin Ryabitsev
2026-02-28 17:12             ` Conor Dooley
2026-02-28 17:21               ` Konstantin Ryabitsev
2026-02-28 17:34                 ` Konstantin Ryabitsev
2026-02-28 18:37                   ` Conor Dooley
2026-02-28 22:16                   ` Conor Dooley
2026-02-28 22:32                     ` Conor Dooley
2026-03-03  5:16                       ` Konstantin Ryabitsev
2026-03-04 21:38                         ` Conor Dooley
2026-03-04 22:40                           ` Konstantin Ryabitsev
2026-03-04 22:55                             ` Conor Dooley
2026-03-05  3:26                               ` Konstantin Ryabitsev
2026-03-05  6:17                             ` Konstantin Ryabitsev
2026-02-28 18:31 ` Michael S. Tsirkin
2026-02-28 20:06   ` Konstantin Ryabitsev
2026-02-28 20:23     ` Michael S. Tsirkin
2026-02-28 20:37       ` Konstantin Ryabitsev
2026-02-28 20:47         ` Michael S. Tsirkin
2026-02-28 20:53           ` Konstantin Ryabitsev
2026-02-28 21:04             ` Michael S. Tsirkin
2026-03-02  9:30 ` Michael S. Tsirkin [this message]
2026-03-02 10:33 ` Michael S. Tsirkin
2026-03-03  1:58 ` Junio C Hamano
2026-03-03  4:26   ` Konstantin Ryabitsev
2026-03-03 11:20     ` Matthieu Baerts
2026-03-04 20:56 ` range-diff hangs Marc Kleine-Budde
2026-03-14  4:20   ` Konstantin Ryabitsev
2026-03-14  9:27     ` Marc Kleine-Budde
2026-03-16 23:28 ` b4 review available in master Jonathan Corbet
2026-03-16 23:41   ` Jonathan Corbet
2026-03-17  0:15     ` Konstantin Ryabitsev
2026-03-17 14:11       ` Jonathan Corbet
2026-03-17 14:23         ` Konstantin Ryabitsev
2026-03-17 20:30           ` Konstantin Ryabitsev
2026-03-17 21:46             ` Jonathan Corbet
2026-03-17 22:39               ` Konstantin Ryabitsev
2026-03-17 23:37                 ` Konstantin Ryabitsev
2026-03-18  7:56                   ` Geert Uytterhoeven
2026-03-18 13:00                     ` Mark Brown
2026-03-18 13:26                     ` Konstantin Ryabitsev
2026-03-18 16:47                   ` Jonathan Corbet
2026-03-18 18:31                     ` Laurent Pinchart
2026-03-18 19:22                     ` Konstantin Ryabitsev
2026-03-17  0:12   ` Konstantin Ryabitsev
2026-03-18 13:43   ` Johannes Thumshirn
2026-03-20 16:53 ` Louis Chauvet
2026-03-20 19:31   ` Konstantin Ryabitsev
2026-03-20 21:14     ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260302035403-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=mricon@kernel.org \
    --cc=tools@kernel.org \
    --cc=users@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox