From: B4 Bugbot <bugbot+b4@kernel.org>
To: broonie@kernel.org, tools@kernel.org, konstantin@linuxfoundation.org
Subject: Re: b4 review handling when base can't be guessed
Date: Tue, 10 Mar 2026 19:09:11 +0000 (UTC) [thread overview]
Message-ID: <20260310-b38491bec3-dea49b25af83@git.kernel.org> (raw)
In-Reply-To: <092a612b-4fa1-4fa7-a872-b3564fcb3749@sirena.org.uk>
Konstantin Ryabitsev writes in commit 9189f0b31a20311748625d0f2f88afbcbc41f4e4:
Add base selection, attestation display, and take confirmation to review TUI
When the base of a series can't be guessed, the review TUI previously
offered no way to specify an alternative base without quitting and
manually checking out a different branch. This was reported by Mark
Brown (bug 38491be).
Improve the review tracking TUI with several interrelated features that
give maintainers better control and visibility during patch review.
Base commit selection: add BaseSelectionScreen modal that lets
maintainers select or override the base commit when checking out a
series for review. The screen tests patch applicability at the chosen
base and shows the resolved SHA on success. A reusable WorkerScreen
modal provides a loading indicator for running callables in worker
threads.
Attestation display: add a checkmark column (A) to the series listing
that shows green when all patches have valid DKIM/patatt signatures.
The details pane shows per-attestor breakdown after the From line.
Schema v5 adds an attestation column to the tracking database, and
check_series_attestation() checks signatures during update and
checkout, storing per-attestor results (signed/nokey/badsig).
Take confirmation: add TakeConfirmScreen as a final step in the take
flow that test-applies patches before executing. This gives maintainers
a chance to back out if the series will not apply cleanly to the target
branch. Ctrl-y is now the confirmation key consistently across all take
flow screens (TakeScreen, CherryPickScreen, TakeConfirmScreen).
Keybinding changes: split the update keybinding so that u updates only
the selected series while U updates all tracked series, with proper
footer grouping. Cursor position is preserved after update operations.
Key changes:
- BaseSelectionScreen with test-apply and resolved SHA display
- WorkerScreen reusable modal for worker thread callables
- Schema v5 migration for attestation column
- check_series_attestation() and _format_attestation() helpers
- TakeConfirmScreen with pre-take applicability check
- u/U keybinding split with cursor preservation
- Documentation updated for all new features
- 27 new tests for attestation and formatting
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://msgid.link/092a612b-4fa1-4fa7-a872-b3564fcb3749@sirena.org.uk # 38491be
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Assisted-by: claude-opus-4-6
--
Deet-doot-dot, I am a bot.
b4 bug tracker (bugspray 0.1-dev)
prev parent reply other threads:[~2026-03-10 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 12:49 b4 review handling when base can't be guessed Mark Brown
2026-03-10 12:59 ` Konstantin Ryabitsev
2026-03-10 13:05 ` Mark Brown
2026-03-10 13:02 ` B4 Bugbot
2026-03-10 19:09 ` B4 Bugbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260310-b38491bec3-dea49b25af83@git.kernel.org \
--to=bugbot+b4@kernel.org \
--cc=broonie@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox