* [PATCH] Fix typo in maintainer docs
@ 2026-03-11 7:40 Brigham Campbell
2026-03-11 14:39 ` Konstantin Ryabitsev
2026-03-11 15:19 ` Konstantin Ryabitsev
0 siblings, 2 replies; 6+ messages in thread
From: Brigham Campbell @ 2026-03-11 7:40 UTC (permalink / raw)
To: konstantin, tools; +Cc: me
Fix a minor typo in the documentation for `b4 review`.
Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
---
Unrelated, but thanks for your work on b4, Konstantin. It's been a
wonderful help to me so far. I expect the new review functionalities to
be very useful for reviewing many patches from kernel mentees.
docs/maintainer/review.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/maintainer/review.rst b/docs/maintainer/review.rst
index 4af5f77..9b6a32d 100644
--- a/docs/maintainer/review.rst
+++ b/docs/maintainer/review.rst
@@ -23,7 +23,7 @@ Getting started
Enrolling a repository
~~~~~~~~~~~~~~~~~~~~~~
-Before you can track series, you need to enrol the repository::
+Before you can track series, you need to enroll the repository::
b4 review enroll [path] [-i identifier]
base-commit: cba5b5a9fd6078646a58531643e7365480504d77
--
2.52.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix typo in maintainer docs
2026-03-11 7:40 [PATCH] Fix typo in maintainer docs Brigham Campbell
@ 2026-03-11 14:39 ` Konstantin Ryabitsev
2026-03-11 15:27 ` Vlastimil Babka
2026-03-11 19:23 ` Brigham Campbell
2026-03-11 15:19 ` Konstantin Ryabitsev
1 sibling, 2 replies; 6+ messages in thread
From: Konstantin Ryabitsev @ 2026-03-11 14:39 UTC (permalink / raw)
To: Brigham Campbell; +Cc: tools
On Wed, Mar 11, 2026 at 01:40:14AM -0600, Brigham Campbell wrote:
> Fix a minor typo in the documentation for `b4 review`.
It's not actually a typo. ;) Welcome to the Canadian spelling where we
arbitrarily spell some things the US way and others the UK way, and many of
them are correct both ways! Like enroll and enrol, which are both accepted in
Canadian spelling. *sigh*
However, since the command is "b4 enroll" and not "b4 enrol" I will take the
patch.
> Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
> ---
>
> Unrelated, but thanks for your work on b4, Konstantin. It's been a
> wonderful help to me so far. I expect the new review functionalities to
> be very useful for reviewing many patches from kernel mentees.
Thank you! That's my hope as well.
Cheers,
-K
> Enrolling a repository
> ~~~~~~~~~~~~~~~~~~~~~~
> -Before you can track series, you need to enrol the repository::
> +Before you can track series, you need to enroll the repository::
>
> b4 review enroll [path] [-i identifier]
>
>
> base-commit: cba5b5a9fd6078646a58531643e7365480504d77
> --
> 2.52.0
>
--
KR
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix typo in maintainer docs
2026-03-11 7:40 [PATCH] Fix typo in maintainer docs Brigham Campbell
2026-03-11 14:39 ` Konstantin Ryabitsev
@ 2026-03-11 15:19 ` Konstantin Ryabitsev
1 sibling, 0 replies; 6+ messages in thread
From: Konstantin Ryabitsev @ 2026-03-11 15:19 UTC (permalink / raw)
To: tools, Brigham Campbell
On Wed, 11 Mar 2026 01:40:14 -0600, Brigham Campbell wrote:
> Fix typo in maintainer docs
Applied, thanks!
[1/1] Fix typo in maintainer docs
commit: 7e1f9916f6fb508264693476d3f80d4aabd5030d
Best regards,
--
KR
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix typo in maintainer docs
2026-03-11 14:39 ` Konstantin Ryabitsev
@ 2026-03-11 15:27 ` Vlastimil Babka
2026-03-11 15:29 ` Konstantin Ryabitsev
2026-03-11 19:23 ` Brigham Campbell
1 sibling, 1 reply; 6+ messages in thread
From: Vlastimil Babka @ 2026-03-11 15:27 UTC (permalink / raw)
To: Konstantin Ryabitsev, Brigham Campbell; +Cc: tools
On 3/11/26 15:39, Konstantin Ryabitsev wrote:
> On Wed, Mar 11, 2026 at 01:40:14AM -0600, Brigham Campbell wrote:
>> Fix a minor typo in the documentation for `b4 review`.
>
> It's not actually a typo. ;) Welcome to the Canadian spelling where we
> arbitrarily spell some things the US way and others the UK way, and many of
> them are correct both ways! Like enroll and enrol, which are both accepted in
> Canadian spelling. *sigh*
>
> However, since the command is "b4 enroll" and not "b4 enrol" I will take the
> patch.
>
>> Signed-off-by: Brigham Campbell <me@brighamcampbell.com>
>> ---
>>
>> Unrelated, but thanks for your work on b4, Konstantin. It's been a
>> wonderful help to me so far. I expect the new review functionalities to
>> be very useful for reviewing many patches from kernel mentees.
>
> Thank you! That's my hope as well.
>
> Cheers,
> -K
>
>> Enrolling a repository
>> ~~~~~~~~~~~~~~~~~~~~~~
>> -Before you can track series, you need to enrol the repository::
>> +Before you can track series, you need to enroll the repository::
^ clever!
>>
>> b4 review enroll [path] [-i identifier]
>>
>>
>> base-commit: cba5b5a9fd6078646a58531643e7365480504d77
>> --
>> 2.52.0
>>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix typo in maintainer docs
2026-03-11 15:27 ` Vlastimil Babka
@ 2026-03-11 15:29 ` Konstantin Ryabitsev
0 siblings, 0 replies; 6+ messages in thread
From: Konstantin Ryabitsev @ 2026-03-11 15:29 UTC (permalink / raw)
To: Vlastimil Babka; +Cc: Brigham Campbell, tools
On Wed, Mar 11, 2026 at 04:27:09PM +0100, Vlastimil Babka wrote:
> >> Enrolling a repository
> >> ~~~~~~~~~~~~~~~~~~~~~~
> >> -Before you can track series, you need to enrol the repository::
> >> +Before you can track series, you need to enroll the repository::
>
> ^ clever!
>
> >>
> >> b4 review enroll [path] [-i identifier]
I bet you find all easter eggs in games as well. ;)
--
KR
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Fix typo in maintainer docs
2026-03-11 14:39 ` Konstantin Ryabitsev
2026-03-11 15:27 ` Vlastimil Babka
@ 2026-03-11 19:23 ` Brigham Campbell
1 sibling, 0 replies; 6+ messages in thread
From: Brigham Campbell @ 2026-03-11 19:23 UTC (permalink / raw)
To: Konstantin Ryabitsev, Brigham Campbell; +Cc: tools
On Wed Mar 11, 2026 at 8:39 AM MDT, Konstantin Ryabitsev wrote:
> It's not actually a typo. ;) Welcome to the Canadian spelling where we
> arbitrarily spell some things the US way and others the UK way, and many of
> them are correct both ways! Like enroll and enrol, which are both accepted in
> Canadian spelling. *sigh*
Shoot, I should have thought to look that up before sending a patch.
Tricky Canadians! Anyways, thanks for taking the patch. If I find any
obvious improvement or quick fix to be made to the new `review` tooling,
I'll send out another.
Cheers,
Brigham
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-03-11 19:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-11 7:40 [PATCH] Fix typo in maintainer docs Brigham Campbell
2026-03-11 14:39 ` Konstantin Ryabitsev
2026-03-11 15:27 ` Vlastimil Babka
2026-03-11 15:29 ` Konstantin Ryabitsev
2026-03-11 19:23 ` Brigham Campbell
2026-03-11 15:19 ` Konstantin Ryabitsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox