From: B4 Bugbot <bugbot+b4@kernel.org>
To: luca.ceresoli@bootlin.com, louis.chauvet@bootlin.org,
mricon@kernel.org, thomas.petazzoni@bootlin.org,
tools@kernel.org
Subject: Re: b4 shazam applies unrelated patches due to dfblob collision (b4 0.14.3)
Date: Mon, 16 Mar 2026 17:48:55 +0000 (UTC) [thread overview]
Message-ID: <20260316-bb9c4cdec2-7d562b690fb1@git.kernel.org> (raw)
In-Reply-To: <DFUF52RW81LD.28YE20HG4P0L1@bootlin.com>
Konstantin Ryabitsev writes in commit 8a652aeaaa90be4c26d7c2fb5cf899840c737ebd:
Fix get_extra_series pulling in unrelated prerequisite series
When searching for newer revisions by change-id, the nq: query on
lore can match messages that reference our change-id in a
prerequisite-change-id trailer rather than as their own change-id.
This causes get_extra_series to pull in entirely unrelated series,
which b4 then treats as the "latest revision" and tries to apply.
After collecting candidate messages from the search, validate that
each revision actually belongs to the same series by checking that
at least one message per revision contains a standalone change-id
line matching ours. Revisions that only reference the change-id as
a prerequisite are rejected.
This affects b4 shazam, b4 review, and b4 diff, which all use
get_extra_series for revision discovery.
Reported-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Closes: https://lore.kernel.org/tools/DFUF52RW81LD.28YE20HG4P0L1@bootlin.com/ # b9c4cde
Signed-off-by: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Assisted-by: claude-opus-4-6
--
Deet-doot-dot, I am a bot.
b4 bug tracker (bugspray 0.1-dev)
prev parent reply other threads:[~2026-03-16 17:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-21 16:47 [BUG?] b4 shazam applies unrelated patches due to dfblob collision (b4 0.14.3) Luca Ceresoli
2026-03-06 0:39 ` Konstantin Ryabitsev
2026-03-06 0:41 ` B4 Bugbot
2026-03-16 17:48 ` B4 Bugbot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316-bb9c4cdec2-7d562b690fb1@git.kernel.org \
--to=bugbot+b4@kernel.org \
--cc=louis.chauvet@bootlin.org \
--cc=luca.ceresoli@bootlin.com \
--cc=mricon@kernel.org \
--cc=thomas.petazzoni@bootlin.org \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox