From: Tamir Duberstein <tamird@kernel.org>
To: "\"Kernel.org Tools\"" <tools@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Codex <noreply@openai.com>, Tamir Duberstein <tamird@kernel.org>
Subject: [PATCH b4] review: suspend before tracking saves
Date: Mon, 16 Mar 2026 10:48:39 -0400 [thread overview]
Message-ID: <20260316-followup-tui-bad-v1-1-ebe1beab9804@kernel.org> (raw)
Wrap review TUI tracking saves in self.suspend() so interactive git
signing and pinentry own the terminal cleanly. This avoids sluggish
input and swallowed keystrokes when follow-up loading triggers a
tracking save.
Co-authored-by: Codex <noreply@openai.com>
---
Signed-off-by: Tamir Duberstein <tamird@kernel.org>
---
src/b4/review_tui/_review_app.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/b4/review_tui/_review_app.py b/src/b4/review_tui/_review_app.py
index 4a3c5bf..2c4d515 100644
--- a/src/b4/review_tui/_review_app.py
+++ b/src/b4/review_tui/_review_app.py
@@ -1869,7 +1869,8 @@ class ReviewApp(CheckRunnerMixin, App[None]):
def _save_tracking(self) -> None:
"""Save tracking data to the review branch."""
- b4.review.save_tracking(self._topdir, self._cover_text, self._tracking)
+ with self.suspend():
+ b4.review.save_tracking(self._topdir, self._cover_text, self._tracking)
def action_suspend(self) -> None:
"""Suspend the TUI and drop to an interactive shell."""
---
base-commit: 5154a8c9934cd97d05e2c5c479a87b3b9cad7615
change-id: 20260316-followup-tui-bad-48391d2ba4b2
Best regards,
--
Tamir Duberstein <tamird@kernel.org>
next reply other threads:[~2026-03-16 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-16 14:48 Tamir Duberstein [this message]
2026-03-16 15:11 ` [PATCH b4] review: suspend before tracking saves Konstantin Ryabitsev
2026-03-16 15:24 ` Tamir Duberstein
2026-03-16 15:31 ` Konstantin Ryabitsev
2026-03-16 15:36 ` Tamir Duberstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260316-followup-tui-bad-v1-1-ebe1beab9804@kernel.org \
--to=tamird@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=noreply@openai.com \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox