Clarity of pending sashiko reviews

Clarity of pending sashiko reviews

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Hi,

When a Sashiko URL is configured (should that possibly default to
https://sashiko.dev?) but it's not yet processed a patch then it
provides a warning "Review in review" and links to the specific
https://sashiko.dev/patch/NNNN review.  When the review didn't happen
yet that's a 404 which isn't good, it would be better to link to the
https://sashiko.dev/patchset/MSGID URL.  

Ideally Sashiko would have a page at the per patch review, assuming the
URL is usefully discoverable, but probably b4 can detect the 404?

Thanks,
Mark

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Clarity of pending sashiko reviews

[Konstantin Ryabitsev]

On Mon, Mar 23, 2026 at 04:34:40PM +0000, Mark Brown wrote:
> When a Sashiko URL is configured (should that possibly default to
> https://sashiko.dev?) but it's not yet processed a patch then it
> provides a warning "Review in review" and links to the specific
> https://sashiko.dev/patch/NNNN review.  When the review didn't happen
> yet that's a 404 which isn't good, it would be better to link to the
> https://sashiko.dev/patchset/MSGID URL.  
> 
> Ideally Sashiko would have a page at the per patch review, assuming the
> URL is usefully discoverable, but probably b4 can detect the 404?

Yes, the integration is fairly minimal right now and will already require
adjusting if/when sashiko.dev starts sending public follow-up emails, as they
will start to clash with the ones we're loading via the API.

bugspray tag b4/review

-K

Re: Clarity of pending sashiko reviews

[B4 Bugbot]

Hello:

This conversation is now tracked by b4 bug tracker.
There is no need to do anything else, just keep talking.

--
Deet-doot-dot, I am a bot.
b4 bug tracker (bugspray 0.1-dev)