Linux maintainer tooling and workflows
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: "Kernel.org Tools" <tools@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
	 "Christian Brauner (Amutable)" <brauner@kernel.org>
Subject: [PATCH RFC 00/11] review: track and browse every version of a tracked series
Date: Sat, 18 Jul 2026 00:37:36 +0200	[thread overview]
Message-ID: <20260718-work-b4-multiver-rows-v1-0-3c539d2a3095@kernel.org> (raw)

The review TUI binds all mail visibility to the revision a series is
tracked at: 'e' opens only the tracked thread, unread badges exist
only on the series row, and u/U updates poll only the tracked
revision.  Earlier versions of a series -- and the discussion that
shaped it -- are invisible even though the revisions catalog knows
they exist.

Make every known version of a tracked series a first-class citizen of
the mail-tracking machinery:

- The revisions catalog grows per-revision message counts (schema
  v11).  Reads stitch the series row over the catalog so the tracked
  revision's live counts win while archived upgrade leftovers never
  shadow anything.

- u/U updates poll every cataloged revision for new mail using the
  same incremental thread queries used elsewhere: zero database
  writes when a thread is quiet, a full refetch plus git-blob caching
  when something new arrived.  Rethreaded revisions sum their
  per-patch threads.

- A new "Find older revisions" action runs the b4 am/mbox backward
  search (change-id query when the cover carries one, subject+sender
  otherwise) with an explicit wantvers covering every previous
  version, records what it finds, and polls the new entries
  immediately so they arrive with counts and cached threads.  A
  retitled series without a change-id still needs manual linking --
  the same limitation b4 am -vN has.

- The tracker list gains expandable per-version rows: 'x' unfolds a
  series into child rows (tracked revision starred) with their own
  unread badges and activity dates, 'X' toggles all series at once.
  Enter/'e' on a child opens that version's thread with
  revision-correct seen syncing, and 'd' range-diffs it against the
  tracked revision directly.  Expansion and cursor state survive the
  periodic DB reloads and limit filtering.

Message-level read state was already keyed by message-id alone, so
Seen/Flagged/Answered flags apply across versions unchanged; this
series adds the missing count/badge and navigation layers on top.

Also included is a standalone fix for 'e' on rethreaded series, which
never passed is_rethreaded and thus fetched a single patch's thread
instead of reassembling the series from its per-patch message-ids.

The series is bisectable, with implementation and tests split
throughout.

Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
---
Christian Brauner (11):
      review-tui: fix rethreaded series thread viewing
      review: track message counts for all revisions of a series
      review: test per-revision message tracking
      review-tui: poll every revision on u/U updates
      review-tui: guarantee the tracked revision in revision lists
      review: add backward discovery of older series revisions
      review-tui: add a "Find older revisions" action
      review: test backward revision discovery
      review-tui: extract the Msgs column renderer from TrackedSeriesItem
      review-tui: expand tracked series into per-version rows
      review-tui: test per-version tracker rows

 src/b4/review/tracking.py          | 636 ++++++++++++++++++++++++----
 src/b4/review_tui/_lite_app.py     |   1 +
 src/b4/review_tui/_modals.py       |  27 ++
 src/b4/review_tui/_tracking_app.py | 464 ++++++++++++++++++---
 src/tests/test_review_tracking.py  | 823 +++++++++++++++++++++++++++++++++++++
 src/tests/test_tui_tracking.py     | 578 +++++++++++++++++++++++++-
 6 files changed, 2393 insertions(+), 136 deletions(-)
---
base-commit: 4217c3e5d3e1eb259626142fd71b91ec6d5e3d1e
change-id: 20260718-work-b4-multiver-rows-6032fb71e951


             reply	other threads:[~2026-07-17 22:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 22:37 Christian Brauner [this message]
2026-07-17 22:37 ` [PATCH RFC 01/11] review-tui: fix rethreaded series thread viewing Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 02/11] review: track message counts for all revisions of a series Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 03/11] review: test per-revision message tracking Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 04/11] review-tui: poll every revision on u/U updates Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 05/11] review-tui: guarantee the tracked revision in revision lists Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 06/11] review: add backward discovery of older series revisions Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 07/11] review-tui: add a "Find older revisions" action Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 08/11] review: test backward revision discovery Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 09/11] review-tui: extract the Msgs column renderer from TrackedSeriesItem Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 10/11] review-tui: expand tracked series into per-version rows Christian Brauner
2026-07-17 22:37 ` [PATCH RFC 11/11] review-tui: test per-version tracker rows Christian Brauner
2026-07-27 20:43 ` [PATCH RFC 00/11] review: track and browse every version of a tracked series Konstantin Ryabitsev
2026-07-27 21:27   ` Christian Brauner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260718-work-b4-multiver-rows-v1-0-3c539d2a3095@kernel.org \
    --to=brauner@kernel.org \
    --cc=konstantin@linuxfoundation.org \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox