From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: tools@kernel.org
Subject: Re: b4 filters out Fixes: lines
Date: Tue, 11 Aug 2026 17:12:53 -0400 [thread overview]
Message-ID: <20260811-adaptable-amaranth-salmon-596eba@meerkat> (raw)
In-Reply-To: <CAMxuvawkMqDYVP6T85+s6FwDzp5B33eWNHjkjoAoW+C4OnuZYQ@mail.gmail.com>
On Mon, Aug 10, 2026 at 11:59:59AM +0400, Marc-André Lureau wrote:
> Since commit dccab10473b5 ("trailers: reject malformed Fixes: trailer
> values"), b4 filters out anything that is not a commit hash-like line.
> But various projects, such as QEMU, use Fixes: lines to reference CVE#
> and sometime report/issue URLs. Can we relax the validation? Should we
> make this configurable?
Right, this was tightened because "Fixes:" is a one-word trailer and we can
legitimately find it on the line followed by arbitrary prose.
I'm not against broadening it to include URLs, but I'm less sure about
arbitrary strings like CVE-NNNN-NNN.
Regarding making it configurable, it would probably be more worthwhile to make
the whole list of follow-up trailers configurable, as a list of regexes, e.g.:
b4.followup-trailers =
Fixes: CVE-.*
Fixes: https?://.*
Closes: https?://.*
I'd lean in this direction as opposed to just a special-case for the Fixes:
trailer.
-K
prev parent reply other threads:[~2026-08-11 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 7:59 b4 filters out Fixes: lines Marc-André Lureau
2026-08-11 21:12 ` Konstantin Ryabitsev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811-adaptable-amaranth-salmon-596eba@meerkat \
--to=konstantin@linuxfoundation.org \
--cc=marcandre.lureau@redhat.com \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox