public inbox for tools@linux.kernel.org
 help / color / mirror / Atom feed
From: Louis Chauvet <louis.chauvet@bootlin.com>
To: Konstantin Ryabitsev <mricon@kernel.org>,
	users@kernel.org, tools@kernel.org
Subject: Re: b4 review available in master
Date: Fri, 20 Mar 2026 17:53:12 +0100	[thread overview]
Message-ID: <24351d92-3f8c-412b-807d-ed7ee0b1ebf6@bootlin.com> (raw)
In-Reply-To: <20260227-imported-aromatic-guppy-ad3dca@lemur>



On 2/27/26 20:53, Konstantin Ryabitsev wrote:
> Hi, all:
> 
> TLDR: "b4 review" is a terminal UI that hopes to streamline a lot of
> maintainer duties. A getting-started guide with screencasts is here:
> https://b4.docs.kernel.org/en/latest/reviewer/getting-started.html
> 
> It's available from b4 master pending initial testing and will be generally
> available in b4-0.15.

Hi everyone,

I’ve been testing the review tool and it’s working very well! Congrats 
for this tool!

I’ve encountered a small issue while trying to review/test the following 
series:

     20260313132103.2529746-1-jim.cromie@gmail.com

When forcing drm-misc/drm-misc-next base, the check fails. I tried to 
force the acceptation (^y), but I got a git am issue during the branch 
creation (I fixed it manually, so my issue is "solved").

According to the documentation[1], it should use git am -3, so I tried 
(in an other worktree, rerere disabled) to run b4 am -3 && git am -3, 
and it worked (you need to fetch https://github.com/jimc/linux). I don't 
understand why it doesn't work in b4 review.

Did I misunderstood something in the documentation? Do I have an issue 
in my configuration? If not, can you add a way to apply the series with 
git am -3?

Small list of "stuff I found when using the tool" (I totally accept a 
"totally useless / don't have time / bad idea", the tool is already very 
nice) :
- Add a way to see application logs (notably git errors)
- Add a way to read the existing trailers to mark patches as "done" (in 
the above series, I already reviewed few patches, but they are not 
marked as done in the tui).
- Copy don't work  in the tui, it is a bit annoying (for example copy 
git hash, text)
- When you exit, if a process was started in background (for example the 
base check), they are not cancelled and the tool waits until completion 
(not an issue for small series, but in my case the series is 63 patches, 
so it can take up to 1 minute)
- Add a way to select and add trailers on multiple patches at the same time
- If a trailer is added in the `reply` interface, don't move it, I often 
use and see stuff like `with or without this: R-by`, this is 
"contextual", so could be nice to keep it in place.
- Add a config to disable "autosnip" (I understand the goal, but a per 
patch "on/off" could be useful)
- Add a "quick shortcut" to add trailers (t -> r/a/t/n -> enter instead 
of t -> arrows -> space -> enter)
- Add a way to disable the scroll animation (pgup/down do a "smooth" 
scroll, which is very strange in a terminal) (very personal feeling)
- Scroll using arrows/pgupdown/jk don't work in the "send email" 
confirmation list

Best regards,
Louis

[1]:https://b4.docs.kernel.org/en/latest/maintainer/review.html#conflict-resolution

  parent reply	other threads:[~2026-03-20 16:52 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-27 19:53 b4 review available in master Konstantin Ryabitsev
2026-02-28 15:12 ` Mark Brown
2026-02-28 15:47   ` Konstantin Ryabitsev
2026-02-28 16:00     ` Konstantin Ryabitsev
2026-02-28 18:12       ` Mark Brown
2026-02-28 15:53 ` Mark Brown
2026-02-28 21:11   ` Mark Brown
2026-03-03  5:14     ` Konstantin Ryabitsev
2026-03-03 12:42       ` Mark Brown
2026-03-03 18:21         ` Konstantin Ryabitsev
2026-03-12 17:21           ` Alexandre Belloni
2026-03-13 15:42             ` Konstantin Ryabitsev
2026-03-13 15:55               ` Alexandre Belloni
2026-03-21 10:01                 ` Alexandre Belloni
2026-03-12 17:35           ` Mark Brown
2026-03-13 15:42             ` Konstantin Ryabitsev
2026-02-28 16:36 ` Conor Dooley
2026-02-28 16:45   ` Konstantin Ryabitsev
2026-02-28 16:48     ` Conor Dooley
2026-02-28 16:57       ` Konstantin Ryabitsev
2026-02-28 17:00         ` Conor Dooley
2026-02-28 17:05           ` Konstantin Ryabitsev
2026-02-28 17:12             ` Conor Dooley
2026-02-28 17:21               ` Konstantin Ryabitsev
2026-02-28 17:34                 ` Konstantin Ryabitsev
2026-02-28 18:37                   ` Conor Dooley
2026-02-28 22:16                   ` Conor Dooley
2026-02-28 22:32                     ` Conor Dooley
2026-03-03  5:16                       ` Konstantin Ryabitsev
2026-03-04 21:38                         ` Conor Dooley
2026-03-04 22:40                           ` Konstantin Ryabitsev
2026-03-04 22:55                             ` Conor Dooley
2026-03-05  3:26                               ` Konstantin Ryabitsev
2026-03-05  6:17                             ` Konstantin Ryabitsev
2026-02-28 18:31 ` Michael S. Tsirkin
2026-02-28 20:06   ` Konstantin Ryabitsev
2026-02-28 20:23     ` Michael S. Tsirkin
2026-02-28 20:37       ` Konstantin Ryabitsev
2026-02-28 20:47         ` Michael S. Tsirkin
2026-02-28 20:53           ` Konstantin Ryabitsev
2026-02-28 21:04             ` Michael S. Tsirkin
2026-03-02  9:30 ` Michael S. Tsirkin
2026-03-02 10:33 ` Michael S. Tsirkin
2026-03-03  1:58 ` Junio C Hamano
2026-03-03  4:26   ` Konstantin Ryabitsev
2026-03-03 11:20     ` Matthieu Baerts
2026-03-04 20:56 ` range-diff hangs Marc Kleine-Budde
2026-03-14  4:20   ` Konstantin Ryabitsev
2026-03-14  9:27     ` Marc Kleine-Budde
2026-03-16 23:28 ` b4 review available in master Jonathan Corbet
2026-03-16 23:41   ` Jonathan Corbet
2026-03-17  0:15     ` Konstantin Ryabitsev
2026-03-17 14:11       ` Jonathan Corbet
2026-03-17 14:23         ` Konstantin Ryabitsev
2026-03-17 20:30           ` Konstantin Ryabitsev
2026-03-17 21:46             ` Jonathan Corbet
2026-03-17 22:39               ` Konstantin Ryabitsev
2026-03-17 23:37                 ` Konstantin Ryabitsev
2026-03-18  7:56                   ` Geert Uytterhoeven
2026-03-18 13:00                     ` Mark Brown
2026-03-18 13:26                     ` Konstantin Ryabitsev
2026-03-18 16:47                   ` Jonathan Corbet
2026-03-18 18:31                     ` Laurent Pinchart
2026-03-18 19:22                     ` Konstantin Ryabitsev
2026-03-17  0:12   ` Konstantin Ryabitsev
2026-03-18 13:43   ` Johannes Thumshirn
2026-03-20 16:53 ` Louis Chauvet [this message]
2026-03-20 19:31   ` Konstantin Ryabitsev
2026-03-20 21:14     ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24351d92-3f8c-412b-807d-ed7ee0b1ebf6@bootlin.com \
    --to=louis.chauvet@bootlin.com \
    --cc=mricon@kernel.org \
    --cc=tools@kernel.org \
    --cc=users@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox