public inbox for tools@linux.kernel.org
 help / color / mirror / Atom feed
From: Chris Samuel <chris@csamuel.org>
To: tools@kernel.org
Subject: b4 review experience
Date: Sat, 21 Mar 2026 22:11:32 -0400	[thread overview]
Message-ID: <2c1ab8a2-8a86-48a7-9a53-ef3a00ab4bd2@csamuel.org> (raw)

Hi there,

First of all thanks so much for this work, it looks really nice!  I'll 
also preface this by saying I'm not a kernel person, I'm not even really 
a programmer, just a sysadmin who likes to track what's going on in 
certain parts of the kernel.

Having seen Jon Corbet's mentions of the new "b4 review" feature I 
decided to try "b4" out from the git repo and I've got to say I really 
like it. It took me a minute to get to grips with it but I'm enjoying 
how it lets me look at patchsets and comments on them.

One thing I've noticed is that if the patch set is large then I can't 
scroll the list of patches on the left hand side of the review view with 
the mouse, though I can use the arrow keys to go through the patches.

A similar issue that if I run the CI (to get checkpatch and Sashiko 
input) I can scroll the list with the mouse, but I can't select any of 
the patches with the mouse. I can move through the list with the arrow 
keys but when I get to the bottom of the screen it doesn't scroll. I can 
scroll with the mouse to see where it's got to, but as soon as I press 
an arrow key it resets to the start of the list.

The only other thing I'll mention is that with the checkpatch output 
it'd be handy (for the complaints about lines in the commit message) if 
it showed the context like it does when you run it at the command line.

For my experiments I've been using two of the MPAM patchsets:

https://lore.kernel.org/lkml/20260319162225.378485-1-ben.horgan@arm.com/

That set has the checkpatch failure init.

https://lore.kernel.org/lkml/20260313144617.3420416-1-ben.horgan@arm.com/

That is the large (40 patch) set I mention.

But again, I really like this and for alpha code it's pretty good!

Thank you, all the best,
Chris
-- 
Chris Samuel  :  http://www.csamuel.org/  :  Philadelphia, PA, USA


             reply	other threads:[~2026-03-22  2:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-22  2:11 Chris Samuel [this message]
2026-03-24 18:42 ` b4 review experience Konstantin Ryabitsev
2026-03-25  0:46   ` Chris Samuel
2026-03-25  0:51     ` Chris Samuel
2026-03-27 21:00       ` Konstantin Ryabitsev
2026-03-28 12:18         ` Chris Samuel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c1ab8a2-8a86-48a7-9a53-ef3a00ab4bd2@csamuel.org \
    --to=chris@csamuel.org \
    --cc=tools@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox