From: Matthieu Baerts <matttbe@kernel.org>
To: Sven Eckelmann <sven@narfation.org>,
"Kernel.org Tools" <tools@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Subject: Re: [PATCH b4] review: Fix sashiko patchset URL format
Date: Wed, 29 Apr 2026 12:13:32 +0200 [thread overview]
Message-ID: <3cd8a333-1724-45c0-b288-b82480781471@kernel.org> (raw)
In-Reply-To: <20260429-sashiko-patchset-url-v1-1-de8027029bca@narfation.org>
Hi Sven,
On 29/04/2026 11:54, Sven Eckelmann wrote:
> The sashiko server does not expose a direct `/patch/{ps_id}` endpoint.
> Requesting https://sashiko.dev/patch/93 returns a 404, because the frontend
> is a JavaScript single page application (SPA) that relies on the API to
> fetch and render content dynamically.
>
> The correct approach is to load the root page and pass the resource as a
> URL fragment (anchor), e.g. https://sashiko.dev/#/patchset/93, so the SPA
> can query the API and display the patchset accordingly.
Thank you for sharing this. It looks like your patch is similar to this one:
https://lore.kernel.org/tools/20260428-sashiko-patchset-api-v1-2-24d4ac34b4ae@kernel.org/T/#u
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2026-04-29 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 9:54 [PATCH b4] review: Fix sashiko patchset URL format Sven Eckelmann
2026-04-29 10:13 ` Matthieu Baerts [this message]
2026-04-29 11:24 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cd8a333-1724-45c0-b288-b82480781471@kernel.org \
--to=matttbe@kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=sven@narfation.org \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox