From: Kevin Hilman <khilman@baylibre.com>
To: Louis Chauvet <louis.chauvet@bootlin.com>,
"Kernel.org Tools" <tools@kernel.org>
Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Louis Chauvet <louis.chauvet@bootlin.com>
Subject: Re: [PATCH b4] Remove message-id from cc list
Date: Thu, 05 Sep 2024 15:20:16 -0700 [thread overview]
Message-ID: <7hikv9agkf.fsf@baylibre.com> (raw)
In-Reply-To: <draft-7ho75avvwk.fsf@baylibre.com>
Kevin Hilman <khilman@baylibre.com> writes:
> Louis Chauvet <louis.chauvet@bootlin.com> writes:
>
>> As the algorithm to detect mails to add in CC is very simple, it also
>> include the prerequisite-message-id to CC as they look like mails. In
>> order to avoid this kind of issue, filter out prerequisite-message-id
>> lines.
>>
>> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
>> ---
>> src/b4/__init__.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/b4/__init__.py b/src/b4/__init__.py
>> index ec230e7ace66..b0d91c0e4017 100644
>> --- a/src/b4/__init__.py
>> +++ b/src/b4/__init__.py
>> @@ -1990,7 +1990,7 @@ class LoreMessage:
>>
>> @staticmethod
>> def find_trailers(body: str, followup: bool = False) -> Tuple[List[LoreTrailer], List[str]]:
>> - ignores = {'phone', 'email'}
>> + ignores = {'phone', 'email', 'prerequisite-message-id'}
>> headers = {'subject', 'date', 'from'}
>> links = {'link', 'buglink', 'closes'}
>> nonperson = links | {'fixes', 'subject', 'date', 'obsoleted-by', 'change-id', 'base-commit'}
>>
>> ---
>> base-commit: 99b128995f27cd9aa6fa8adf7588f339919ac14d
>> change-id: 20240828-remove-invalid-cc-eecbd7d43b3d
>
> I have not been able to test (yet), but I'm guessing this should fix this
> bug[1] I reported a couple weeks ago.
I can now confirm that this patch fixes this bug[1].
Thanks Louis for the fix!
Kevin
P.S. is there some bugbot magic to connect this thread to an existing bug?
[1] https://bugzilla.kernel.org/show_bug.cgi?id=219138
next prev parent reply other threads:[~2024-09-05 22:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 9:39 [PATCH b4] Remove message-id from cc list Louis Chauvet
2024-08-29 10:14 ` [PATCH] " Manos Pitsidianakis
2024-08-30 16:05 ` [PATCH b4] " Kevin Hilman
[not found] ` <draft-7ho75avvwk.fsf@baylibre.com>
2024-09-05 22:20 ` Kevin Hilman [this message]
2024-09-06 14:24 ` Konstantin Ryabitsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hikv9agkf.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=konstantin@linuxfoundation.org \
--cc=louis.chauvet@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tools@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).