* [PATCH b4] Remove message-id from cc list
@ 2024-08-28 9:39 Louis Chauvet
2024-08-29 10:14 ` [PATCH] " Manos Pitsidianakis
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Louis Chauvet @ 2024-08-28 9:39 UTC (permalink / raw)
To: Kernel.org Tools; +Cc: Konstantin Ryabitsev, Thomas Petazzoni, Louis Chauvet
As the algorithm to detect mails to add in CC is very simple, it also
include the prerequisite-message-id to CC as they look like mails. In
order to avoid this kind of issue, filter out prerequisite-message-id
lines.
Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
---
src/b4/__init__.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/b4/__init__.py b/src/b4/__init__.py
index ec230e7ace66..b0d91c0e4017 100644
--- a/src/b4/__init__.py
+++ b/src/b4/__init__.py
@@ -1990,7 +1990,7 @@ class LoreMessage:
@staticmethod
def find_trailers(body: str, followup: bool = False) -> Tuple[List[LoreTrailer], List[str]]:
- ignores = {'phone', 'email'}
+ ignores = {'phone', 'email', 'prerequisite-message-id'}
headers = {'subject', 'date', 'from'}
links = {'link', 'buglink', 'closes'}
nonperson = links | {'fixes', 'subject', 'date', 'obsoleted-by', 'change-id', 'base-commit'}
---
base-commit: 99b128995f27cd9aa6fa8adf7588f339919ac14d
change-id: 20240828-remove-invalid-cc-eecbd7d43b3d
Best regards,
--
Louis Chauvet <louis.chauvet@bootlin.com>
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] Remove message-id from cc list
2024-08-28 9:39 [PATCH b4] Remove message-id from cc list Louis Chauvet
@ 2024-08-29 10:14 ` Manos Pitsidianakis
2024-08-30 16:05 ` [PATCH b4] " Kevin Hilman
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Manos Pitsidianakis @ 2024-08-29 10:14 UTC (permalink / raw)
To: Kernel.org Tools; +Cc: Konstantin Ryabitsev, Thomas Petazzoni, Louis Chauvet
On Wed, 28 Aug 2024 12:39, Louis Chauvet <louis.chauvet@bootlin.com> wrote:
>As the algorithm to detect mails to add in CC is very simple, it also
>include the prerequisite-message-id to CC as they look like mails. In
>order to avoid this kind of issue, filter out prerequisite-message-id
>lines.
>
>Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
>---
> src/b4/__init__.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/src/b4/__init__.py b/src/b4/__init__.py
>index ec230e7ace66..b0d91c0e4017 100644
>--- a/src/b4/__init__.py
>+++ b/src/b4/__init__.py
>@@ -1990,7 +1990,7 @@ class LoreMessage:
>
> @staticmethod
> def find_trailers(body: str, followup: bool = False) -> Tuple[List[LoreTrailer], List[str]]:
>- ignores = {'phone', 'email'}
>+ ignores = {'phone', 'email', 'prerequisite-message-id'}
> headers = {'subject', 'date', 'from'}
> links = {'link', 'buglink', 'closes'}
> nonperson = links | {'fixes', 'subject', 'date', 'obsoleted-by', 'change-id', 'base-commit'}
>
>---
>base-commit: 99b128995f27cd9aa6fa8adf7588f339919ac14d
>change-id: 20240828-remove-invalid-cc-eecbd7d43b3d
>
>Best regards,
>--
>Louis Chauvet <louis.chauvet@bootlin.com>
>
Reviewed-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Tested-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH b4] Remove message-id from cc list
2024-08-28 9:39 [PATCH b4] Remove message-id from cc list Louis Chauvet
2024-08-29 10:14 ` [PATCH] " Manos Pitsidianakis
@ 2024-08-30 16:05 ` Kevin Hilman
[not found] ` <draft-7ho75avvwk.fsf@baylibre.com>
2024-09-06 14:24 ` Konstantin Ryabitsev
3 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2024-08-30 16:05 UTC (permalink / raw)
To: Louis Chauvet, Kernel.org Tools
Cc: Konstantin Ryabitsev, Thomas Petazzoni, Louis Chauvet
Louis Chauvet <louis.chauvet@bootlin.com> writes:
> As the algorithm to detect mails to add in CC is very simple, it also
> include the prerequisite-message-id to CC as they look like mails. In
> order to avoid this kind of issue, filter out prerequisite-message-id
> lines.
>
> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
> ---
> src/b4/__init__.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/b4/__init__.py b/src/b4/__init__.py
> index ec230e7ace66..b0d91c0e4017 100644
> --- a/src/b4/__init__.py
> +++ b/src/b4/__init__.py
> @@ -1990,7 +1990,7 @@ class LoreMessage:
>
> @staticmethod
> def find_trailers(body: str, followup: bool = False) -> Tuple[List[LoreTrailer], List[str]]:
> - ignores = {'phone', 'email'}
> + ignores = {'phone', 'email', 'prerequisite-message-id'}
> headers = {'subject', 'date', 'from'}
> links = {'link', 'buglink', 'closes'}
> nonperson = links | {'fixes', 'subject', 'date', 'obsoleted-by', 'change-id', 'base-commit'}
>
> ---
> base-commit: 99b128995f27cd9aa6fa8adf7588f339919ac14d
> change-id: 20240828-remove-invalid-cc-eecbd7d43b3d
I have not been able to test (yet), but I'm guessing this should fix this
bug[1] I reported a couple weeks ago.
Thanks for the fix!
Kevin
[1] https://bugzilla.kernel.org/show_bug.cgi?id=219138
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <draft-7ho75avvwk.fsf@baylibre.com>]
* Re: [PATCH b4] Remove message-id from cc list
[not found] ` <draft-7ho75avvwk.fsf@baylibre.com>
@ 2024-09-05 22:20 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2024-09-05 22:20 UTC (permalink / raw)
To: Louis Chauvet, Kernel.org Tools
Cc: Konstantin Ryabitsev, Thomas Petazzoni, Louis Chauvet
Kevin Hilman <khilman@baylibre.com> writes:
> Louis Chauvet <louis.chauvet@bootlin.com> writes:
>
>> As the algorithm to detect mails to add in CC is very simple, it also
>> include the prerequisite-message-id to CC as they look like mails. In
>> order to avoid this kind of issue, filter out prerequisite-message-id
>> lines.
>>
>> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
>> ---
>> src/b4/__init__.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/b4/__init__.py b/src/b4/__init__.py
>> index ec230e7ace66..b0d91c0e4017 100644
>> --- a/src/b4/__init__.py
>> +++ b/src/b4/__init__.py
>> @@ -1990,7 +1990,7 @@ class LoreMessage:
>>
>> @staticmethod
>> def find_trailers(body: str, followup: bool = False) -> Tuple[List[LoreTrailer], List[str]]:
>> - ignores = {'phone', 'email'}
>> + ignores = {'phone', 'email', 'prerequisite-message-id'}
>> headers = {'subject', 'date', 'from'}
>> links = {'link', 'buglink', 'closes'}
>> nonperson = links | {'fixes', 'subject', 'date', 'obsoleted-by', 'change-id', 'base-commit'}
>>
>> ---
>> base-commit: 99b128995f27cd9aa6fa8adf7588f339919ac14d
>> change-id: 20240828-remove-invalid-cc-eecbd7d43b3d
>
> I have not been able to test (yet), but I'm guessing this should fix this
> bug[1] I reported a couple weeks ago.
I can now confirm that this patch fixes this bug[1].
Thanks Louis for the fix!
Kevin
P.S. is there some bugbot magic to connect this thread to an existing bug?
[1] https://bugzilla.kernel.org/show_bug.cgi?id=219138
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH b4] Remove message-id from cc list
2024-08-28 9:39 [PATCH b4] Remove message-id from cc list Louis Chauvet
` (2 preceding siblings ...)
[not found] ` <draft-7ho75avvwk.fsf@baylibre.com>
@ 2024-09-06 14:24 ` Konstantin Ryabitsev
3 siblings, 0 replies; 5+ messages in thread
From: Konstantin Ryabitsev @ 2024-09-06 14:24 UTC (permalink / raw)
To: Kernel.org Tools, Louis Chauvet; +Cc: Thomas Petazzoni
On Wed, 28 Aug 2024 11:39:51 +0200, Louis Chauvet wrote:
> As the algorithm to detect mails to add in CC is very simple, it also
> include the prerequisite-message-id to CC as they look like mails. In
> order to avoid this kind of issue, filter out prerequisite-message-id
> lines.
>
>
Applied, thanks!
[1/1] Remove message-id from cc list
commit: 77eaedc7de548fdaa289c51f62278633bd815d01
Best regards,
--
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-06 14:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-28 9:39 [PATCH b4] Remove message-id from cc list Louis Chauvet
2024-08-29 10:14 ` [PATCH] " Manos Pitsidianakis
2024-08-30 16:05 ` [PATCH b4] " Kevin Hilman
[not found] ` <draft-7ho75avvwk.fsf@baylibre.com>
2024-09-05 22:20 ` Kevin Hilman
2024-09-06 14:24 ` Konstantin Ryabitsev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).